Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing with ruby 3.2, 3.3 (keeping 2.5-2.7) #111

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Testing with ruby 3.2, 3.3 (keeping 2.5-2.7) #111

merged 2 commits into from
Oct 7, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 30, 2024 •
edited
Loading

  • explicitly require 'uri'
  • use latest ruby gems

@jrafanie
Copy link
Member

jrafanie commented Oct 1, 2024

@kbrock looks like an actual 3.3 issue with URI.parse or more specifically the constant lookup for URI. Please take a look.

@kbrock
Copy link
Member Author

kbrock commented Oct 7, 2024 •
edited
Loading

update:

  • explicitly require "uri"

thanks @jrafanie

jrafanie
jrafanie approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit cb9c389 into ManageIQ:master Oct 7, 2024
8 checks passed
@kbrock kbrock deleted the ruby3.3 branch October 8, 2024 15:23
@kbrock kbrock mentioned this pull request Nov 5, 2024
Merged
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
ruby3.3 test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrock @jrafanie