Add logging of timings, counts, and memory usage #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the memory usage logging could go to debug instead of info? |
|
I think debug since once addressed we should not always need it, and it could clutter the logs. |
|
@agrare Looks ok to me, though I agree it should probably be debug level info. |
agrare
force-pushed
the
azure_inventory_collection_logging
branch
from
a22dc2c
to
0ce111e
Compare
|
Okay memory usage logged as debug now |
agrare
force-pushed
the
azure_inventory_collection_logging
branch
2 times, most recently
from
c341b58
to
179f384
Compare
bronaghs
reviewed
Sep 20, 2017
| @template_uris.each { |uri, template| template[:content] = download_template(uri) } | ||
| _log.info("Retrieving templates...Complete - Count [#{@template_uris.count}]") | ||
|
|
agrare
force-pushed
the
azure_inventory_collection_logging
branch
from
179f384
to
14a1779
Compare
|
Checked commit agrare@14a1779 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
changed the title
|
@djberg96 - Can logging be added to the azure-armrest gem where we get private images? That code looks very expensive and I think we could do with some insight there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional logging around collecting inventory specifically how long it took, how many items were returned, and the memory usage after each collection.
https://bugzilla.redhat.com/show_bug.cgi?id=1431912