Add the :all flag for metrics collection

[djberg96]

This addresses a TODO that was mentioned in the metrics collection code. At the moment we collect a maximum of 1000 records at a time. While it's unlikely that there are more than 1000 records in the given time window that we specify, it is possible.

The original issue mentioned was addressed in version 0.9.2 of the azure-armrest gem.

[miq-bot]

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/d76c8cc78c45a299580b54e4fcfb58a5d9eaca7b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/models/manageiq/providers/azure/cloud_manager/metrics_capture.rb

• ❗ - Line 190, Col 7 - Style/AlignParameters - Align the parameters of a method call if they span more than one line.

[bronaghs]

Think the description needs to refer to metrics, not events.

[djberg96]

@bronaghs Updated.

[bronaghs]

@djberg96 - Will this just get the first page of metrics?

[djberg96]

@bronaghs not sure what you mean by the first page. At the moment, the results are capped at 1000 records for the request. By using :all we get all of them.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 9d504446c390c28ecea67c32c75ee4babec0f732
Author: Bronagh Sorota <[email protected]>
Date:   Wed Dec 6 11:14:29 2017 -0500

    Merge pull request #176 from djberg96/all_metrics
    
    Add the :all flag for events collection
    (cherry picked from commit d8f8fa5c23625edce252190aae70f3978dc17054)