Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure graph refresh event target parser #219

Merged

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Mar 6, 2018

Azure graph refresh event target parser + specs. EventTargetParser is invoked by Automate event handler and parses targets from events, that will be queued for the refresh.

Depends on:

Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1487602

@Ladas Ladas requested review from djberg96 and bronaghs March 6, 2018 10:54
@Ladas Ladas force-pushed the azure_graph_refresh_event_target_parser branch 2 times, most recently from 303a065 to 4410134 Compare March 6, 2018 12:18
@Ladas Ladas mentioned this pull request Mar 6, 2018
1 task
@Ladas Ladas force-pushed the azure_graph_refresh_event_target_parser branch 2 times, most recently from beabefc to 9edb09f Compare March 8, 2018 09:11
Queue full network refresh only after full cloud refresh, ignoring
targeted refresh.
Parse resource group as first 5 sections, rather than expecting
a fixes ems_ref size
Fix parsing of managed image
EventTargetParser for Azure
Adding EventTargetParserSpec, testing all events parse
the right targetd, but also that the target can be refreshed
Add mocked event data, that are recorded from the real events
Tweak event data to contain existing ems_refs
@Ladas Ladas force-pushed the azure_graph_refresh_event_target_parser branch from 9edb09f to 907499b Compare March 8, 2018 16:21
@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2018

Checked commits Ladas/manageiq-providers-azure@a773498~...907499b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
17 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@bronaghs
Copy link

bronaghs commented Mar 8, 2018

@djberg96 - Can you review.

Copy link
Collaborator

@djberg96 djberg96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bronaghs bronaghs merged commit 2042769 into ManageIQ:master Mar 8, 2018
@bronaghs bronaghs added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 8, 2018
simaishi pushed a commit that referenced this pull request Mar 22, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit dbe090fba7c994965d12ceb77ac8153270bb5775
Author: Bronagh Sorota <[email protected]>
Date:   Thu Mar 8 17:52:43 2018 -0500

    Merge pull request #219 from Ladas/azure_graph_refresh_event_target_parser
    
    Azure graph refresh event target parser
    (cherry picked from commit 2042769fe278218f4892040191cca1b26593c58d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants