-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure graph refresh event target parser #219
Merged
bronaghs
merged 8 commits into
ManageIQ:master
from
Ladas:azure_graph_refresh_event_target_parser
Mar 8, 2018
Merged
Azure graph refresh event target parser #219
bronaghs
merged 8 commits into
ManageIQ:master
from
Ladas:azure_graph_refresh_event_target_parser
Mar 8, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
force-pushed
the
azure_graph_refresh_event_target_parser
branch
2 times, most recently
from
March 6, 2018 12:18
303a065
to
4410134
Compare
Ladas
force-pushed
the
azure_graph_refresh_event_target_parser
branch
2 times, most recently
from
March 8, 2018 09:11
beabefc
to
9edb09f
Compare
Queue full network refresh only after full cloud refresh, ignoring targeted refresh.
Parse resource group as first 5 sections, rather than expecting a fixes ems_ref size
Fix parsing of managed image
EventTargetParser for Azure
Adding EventTargetParserSpec, testing all events parse the right targetd, but also that the target can be refreshed
Add mocked event data, that are recorded from the real events
Tweak event data to contain existing ems_refs
Ladas
force-pushed
the
azure_graph_refresh_event_target_parser
branch
from
March 8, 2018 16:21
9edb09f
to
907499b
Compare
Checked commits Ladas/manageiq-providers-azure@a773498~...907499b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
bronaghs
approved these changes
Mar 8, 2018
@djberg96 - Can you review. |
djberg96
approved these changes
Mar 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
simaishi
pushed a commit
that referenced
this pull request
Mar 22, 2018
…arser Azure graph refresh event target parser (cherry picked from commit 2042769) https://bugzilla.redhat.com/show_bug.cgi?id=1558078
Gaprindashvili backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure graph refresh event target parser + specs. EventTargetParser is invoked by Automate event handler and parses targets from events, that will be queued for the refresh.
Depends on:
Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1487602