Azure labels and tag mapping support for a new refresh #229

AlexanderZagaynov · 2018-03-20T15:42:13Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1493041
related old refresh type PR: #231
related core repo PR: ManageIQ/manageiq#17212
related UI repo PR: ManageIQ/manageiq-ui-classic#3697

bronaghs · 2018-03-26T13:47:14Z

@AlexanderZagaynov - the BZ for this PR has a target release of 5.8.4 (Fine branch) and this PR is specific to the Graph refresh which is not supported in the Fine release, so this PR cannot be backported. You will have to make a separate PR for the Fine branch to add tagging support for the old refresh. Getting this into the Fine branch is the priority.

cben · 2018-03-27T18:22:26Z

app/models/manageiq/providers/azure/inventory_collection_default/cloud_manager.rb

@@ -60,6 +60,54 @@ def key_pairs(extra_attributes = {})
      super(attributes.merge!(extra_attributes))
    end

+    def vm_and_template_labels(extra_attributes = {})


@Ladas @juliancheal these collections are starting to pile up in multiple providers, do you see a way to share them?
(I'm fine with duplicating for gaprindashvili & fine, then refactoring)

to clarify, I'm not sure sharing vm_and_template_labels/taggings between 2 VM providers is a big win;
I'm more thinking of a "polymorphic" anything-custom-attributes, anything-taggings, something like these:
https://github.com/ManageIQ/manageiq-providers-kubernetes/blob/5ec31943f8/app/models/manageiq/providers/kubernetes/container_manager/inventory_collections.rb#L359-L400

yeah, we should probably try to unify these next, from what I saw, each provider had it slightly different though

Yeah sounds good to me.

JPrause · 2018-04-05T15:31:10Z

@miq-bot add_label blocker

JPrause · 2018-04-05T15:32:16Z

@AlexanderZagaynov do you have an update on the status of this PR.

cben · 2018-04-09T14:14:13Z

Looks great 👍

I don't remember what you decided about 'Vm' type - do you need separate 'AzureVm', 'AmazonVm' types? IMHO better to get just Vm working & merged first, leave sub-types to a follow-up if desired.

bronaghs · 2018-04-09T14:30:04Z

hi @AlexanderZagaynov - Graph refresh was not backported to the Fine branch, so this PR cannot be backported to Fine either. I see you closed the Fine specific implementation #231

AlexanderZagaynov · 2018-04-09T15:46:11Z

https://travis-ci.org/ManageIQ/manageiq-providers-azure/jobs/364111457#L1958 failing because of ManageIQ/manageiq#17212 not merged yet

JPrause · 2018-04-17T14:15:08Z

@AlexanderZagaynov can you add the gaprindashvili/yes and the fine/yes if this can be backported.

AlexanderZagaynov · 2018-04-17T14:26:46Z

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label fine/no

cben · 2018-04-17T14:27:15Z

app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb

@@ -279,6 +283,8 @@ def parse_instance(instance)
          :orchestration_stack => @data_index.fetch_path(:orchestration_stacks, @resource_to_stack[uid]),
          :availability_zone   => @data_index.fetch_path(:availability_zones, 'default'),
          :resource_group      => @data_index.fetch_path(:resource_groups, rg_ems_ref),
+          :labels              => labels,
+          :tags                => map_labels('Vm', labels),


FYI I think this should be 'VmAzure' like in #231, this is based on top of older version of BZ-1493041-old-refresh branch...

I'm going to rebase and add some changes to this PR after #231 will be merged

AlexanderZagaynov · 2018-04-17T14:29:58Z

@JPrause there will be a special version of #231 for a fine branch

miq-bot · 2018-04-18T11:54:44Z

This pull request is not mergeable. Please rebase and repush.

miq-bot · 2018-04-19T12:57:56Z

Checked commits AlexanderZagaynov/manageiq-providers-azure@61ea9f4~...915fda1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 0 offenses detected
Everything looks fine. 🍰

AlexanderZagaynov · 2018-04-19T13:43:32Z

@miq-bot remove-label unmergeable

AlexanderZagaynov · 2018-04-19T13:46:50Z

@cben @Ladas @bronaghs please review

Ladas

👍 Awesome work @AlexanderZagaynov

Azure labels and tag mapping support for a new refresh (cherry picked from commit a1e134c) https://bugzilla.redhat.com/show_bug.cgi?id=1568807

simaishi · 2018-04-23T13:07:17Z

Gaprindashvili backport details:

$ git log -1
commit 769aee2739e4dd00c5aea9f88b63b4373a33faa9
Author: Ladislav Smola <[email protected]>
Date:   Thu Apr 19 17:58:45 2018 +0200

    Merge pull request #229 from AlexanderZagaynov/BZ-1493041
    
    Azure labels and tag mapping support for a new refresh
    (cherry picked from commit a1e134c12beaf61921e9e59bad97b0bcf28eeaa9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1568807

AlexanderZagaynov changed the title ~~[WIP Azure tagging support~~ [WIP] Azure tagging support Mar 22, 2018

miq-bot added the wip label Mar 22, 2018

AlexanderZagaynov force-pushed the BZ-1493041 branch from cc6b2e4 to 43e0441 Compare March 27, 2018 08:48

This was referenced Mar 27, 2018

Azure labels and tags support for old refresh mech #231

Merged

Azure labeling and tagging support ManageIQ/manageiq#17212

Merged

cben reviewed Mar 27, 2018

View reviewed changes

AlexanderZagaynov mentioned this pull request Mar 28, 2018

Azure labeling and tagging support ManageIQ/manageiq-ui-classic#3697

Merged

miq-bot added the blocker label Apr 5, 2018

AlexanderZagaynov force-pushed the BZ-1493041 branch from 43e0441 to 7e93c0a Compare April 9, 2018 12:52

AlexanderZagaynov mentioned this pull request Apr 11, 2018

fix vm and template taggings doubling issue ManageIQ/manageiq#17287

Closed

AlexanderZagaynov force-pushed the BZ-1493041 branch from 04d3085 to b8e0f61 Compare April 12, 2018 16:29

cben reviewed Apr 17, 2018

View reviewed changes

miq-bot added gaprindashvili/yes labels Apr 17, 2018

miq-bot added the unmergeable label Apr 18, 2018

AlexanderZagaynov force-pushed the BZ-1493041 branch 2 times, most recently from 659cf41 to 3efabb6 Compare April 18, 2018 14:37

AlexanderZagaynov changed the title ~~[WIP] Azure tagging support~~ Azure labels and tag mapping support for a new refresh Apr 18, 2018

miq-bot removed the wip label Apr 18, 2018

AlexanderZagaynov force-pushed the BZ-1493041 branch from 3efabb6 to bf13604 Compare April 18, 2018 15:29

Alexander Zagaynov added 2 commits April 19, 2018 14:35

azure labels and tags support for a new refresh

61ea9f4

test azure labels and tags support

915fda1

AlexanderZagaynov force-pushed the BZ-1493041 branch from bf13604 to 915fda1 Compare April 19, 2018 12:53

miq-bot removed the unmergeable label Apr 19, 2018

bronaghs assigned Ladas Apr 19, 2018

Ladas approved these changes Apr 19, 2018

View reviewed changes

Ladas merged commit a1e134c into ManageIQ:master Apr 19, 2018

Ladas added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 19, 2018

AlexanderZagaynov mentioned this pull request Apr 20, 2018

[GAPRINDASHVILI] labels and tags mapping support #243

Closed

simaishi pushed a commit that referenced this pull request Apr 23, 2018

Merge pull request #229 from AlexanderZagaynov/BZ-1493041

769aee2

Azure labels and tag mapping support for a new refresh (cherry picked from commit a1e134c) https://bugzilla.redhat.com/show_bug.cgi?id=1568807

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Apr 23, 2018

AlexanderZagaynov mentioned this pull request Jun 8, 2018

Write specs for tag setting ManageIQ/manageiq-providers-amazon#201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure labels and tag mapping support for a new refresh #229

Azure labels and tag mapping support for a new refresh #229

AlexanderZagaynov commented Mar 20, 2018 •

edited

Loading

bronaghs commented Mar 26, 2018

cben Mar 27, 2018

cben Mar 27, 2018 •

edited

Loading

Ladas Mar 29, 2018

juliancheal Apr 9, 2018

JPrause commented Apr 5, 2018

JPrause commented Apr 5, 2018

cben commented Apr 9, 2018

bronaghs commented Apr 9, 2018

AlexanderZagaynov commented Apr 9, 2018

JPrause commented Apr 17, 2018

AlexanderZagaynov commented Apr 17, 2018

cben Apr 17, 2018

AlexanderZagaynov Apr 17, 2018

AlexanderZagaynov commented Apr 17, 2018

miq-bot commented Apr 18, 2018

miq-bot commented Apr 19, 2018

AlexanderZagaynov commented Apr 19, 2018

AlexanderZagaynov commented Apr 19, 2018

Ladas left a comment

simaishi commented Apr 23, 2018

Azure labels and tag mapping support for a new refresh #229

Azure labels and tag mapping support for a new refresh #229

Conversation

AlexanderZagaynov commented Mar 20, 2018 • edited Loading

bronaghs commented Mar 26, 2018

cben Mar 27, 2018

Choose a reason for hiding this comment

cben Mar 27, 2018 • edited Loading

Choose a reason for hiding this comment

Ladas Mar 29, 2018

Choose a reason for hiding this comment

juliancheal Apr 9, 2018

Choose a reason for hiding this comment

JPrause commented Apr 5, 2018

JPrause commented Apr 5, 2018

cben commented Apr 9, 2018

bronaghs commented Apr 9, 2018

AlexanderZagaynov commented Apr 9, 2018

JPrause commented Apr 17, 2018

AlexanderZagaynov commented Apr 17, 2018

cben Apr 17, 2018

Choose a reason for hiding this comment

AlexanderZagaynov Apr 17, 2018

Choose a reason for hiding this comment

AlexanderZagaynov commented Apr 17, 2018

miq-bot commented Apr 18, 2018

miq-bot commented Apr 19, 2018

AlexanderZagaynov commented Apr 19, 2018

AlexanderZagaynov commented Apr 19, 2018

Ladas left a comment

Choose a reason for hiding this comment

simaishi commented Apr 23, 2018

AlexanderZagaynov commented Mar 20, 2018 •

edited

Loading

cben Mar 27, 2018 •

edited

Loading