Handle providers that may not support managed images or disks #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
changed the title
|
@bsquizz I need to add some specs, but this should work for Azure stack. |
|
Note to self, regenerate the cassettes. |
…hem. Updated flavor count, refreshed cassettes.
|
Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/835c86dfb83eb1a59c896f6d553494810d6f15bc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
djberg96
changed the title
|
@djberg96 Why did this call for all the cassettes to be regenerated? |
|
@bronaghs Because the |
|
Spoke to Dan offline, the change in API version led to the regeneration of many new cassettes. This widespread update did not break any tests. |
|
@djberg96 - can you set the backport labels? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one region (US Gov Iowa) doe not currently support managed images or disks. As a result, the refresh parser will blow up when it attempts to collect that information. This PR adds a check to see if the provider supports managed images and disks before attempting to collect that information. If not it simply returns an empty array.
https://azure.microsoft.com/en-us/global-infrastructure/services/
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1566600
Although the BZ listed above was originally written for Azure Stack, it applies generally.