Persister: optimized InventoryCollection definitions #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizations
This was referenced Jun 21, 2018
|
Checked commit slemrmartin@46da4f3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
slemrmartin
changed the title
|
cc @agrare |
|
Looks like this is failing on the same spec that master is currently failing on |
|
Should be fixed by #273 |
agrare
approved these changes
Jul 12, 2018
agrare
added a commit
that referenced
this pull request
Jul 12, 2018
Persister: optimized InventoryCollection definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations and simplification of InventoryCollection definitions
Issue: ManageIQ/manageiq#17396
What is possible is moved to core