Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to StandardError if a connection cannot be made #278

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Default to StandardError if a connection cannot be made #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/manageiq/providers/azure/manager_mixin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def connection_rescue_block
raise # Raise before falling into catch-all block below
rescue StandardError => err
_log.error("Error Class=#{err.class.name}, Message=#{err.message}, Backtrace=#{err.backtrace}")
raise MiqException::MiqInvalidCredentialsError, _("Unexpected response returned from system: %{error_message}") % {:error_message => err.message}
raise err, _("Unexpected response returned from system: %{error_message}") % {:error_message => err.message}
end

def environment_for(region)
Expand Down
2 changes: 1 addition & 1 deletion spec/models/manageiq/providers/azure/cloud_manager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
end
it "handles unknown error" do
allow(Azure::Armrest::Configuration).to receive(:new).and_raise(StandardError)
expect { @e.verify_credentials }.to raise_error(MiqException::MiqInvalidCredentialsError, /Unexpected response returned*/)
expect { @e.verify_credentials }.to raise_error(StandardError, /Unexpected response returned*/)
end

it "handles incorrect password" do
Expand Down