Create resource group association for instances and managed images #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip |
|
Note that this PR will get type mismatch errors until the change in the core repo is made. |
|
This pull request is not mergeable. Please rebase and repush. |
Add resource group to images. Add specs for resource_group, remove old Vm#resource_group method. Use baked in subscription_id model method. Added a spec for get_rsource_group_ems_ref. Remove an outdated test.
|
Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/0991914c6e08e60122ed49a8684b4b84772d229b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
The core repo was updated: ManageIQ/manageiq#14000 |
djberg96
changed the title
bronaghs
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we collect resource group information, but don't actually create the appropriate association between a resource and its resource group. This PR attempts to implement that, starting with VM instances and managed images.
Note that this will require some modifications to the core repo before it actually works properly. Without them this does nothing of note, though it doesn't cause any breakage.
Addresses #69
Working in conjunction with ManageIQ/manageiq#15187