Make container events belong to pod #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeari
force-pushed
the
container_events_to_pod
branch
from
67d0116
to
09b20cc
Compare
|
For some reason I feel I'd keep the EmsEvents names and translate in automate definitions (ManageIQ/manageiq-content#225), eg. CONTAINER_FAILED would raise MiqEvent containergroup_containerfailed. |
cben
approved these changes
Dec 5, 2017
|
@miq-bot add_label gaprindashvili/yes |
|
@miq-bot add_label fine/yes |
zeari
force-pushed
the
container_events_to_pod
branch
2 times, most recently
from
eb04b65
to
471155e
Compare
zeari
force-pushed
the
container_events_to_pod
branch
from
471155e
to
8a1ffe7
Compare
zeari
force-pushed
the
container_events_to_pod
branch
from
8a1ffe7
to
419f802
Compare
|
Checked commits zeari/manageiq-providers-kubernetes@5a4b012~...419f802 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
ManageIQ/manageiq#16583 was merged. |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Make container events belong to pod (cherry picked from commit ba505c1) https://bugzilla.redhat.com/show_bug.cgi?id=1530651
|
Gaprindashvili backport details: |
|
Fine backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1496179
This makes
event_data[:event_type]equalPOD_FAILEDinstead of
CONTAINER_FAILEDpart of ManageIQ/manageiq#16583
@cben @moolitayer @enoodle Please review