Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kernel.taint #199

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Remove Kernel.taint #199

merged 4 commits into from
Sep 24, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 19, 2024

Taint tracking removed in ruby 2.7
Added deprecation warning message in ruby 3.2
Removed in ruby 3.3

Taint tracking removed in ruby 2.7
Added deprecation warning message in ruby 3.2
Removed in ruby 3.3
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare Please review

.github/workflows/ci.yaml Show resolved Hide resolved
@Fryguy Fryguy closed this Sep 20, 2024
@Fryguy Fryguy reopened this Sep 20, 2024
@Fryguy
Copy link
Member

Fryguy commented Sep 20, 2024

Lol the branch name.

Aside, seems like you need the File.exist? change in this repo too

@kbrock
Copy link
Member Author

kbrock commented Sep 24, 2024

update:

  • added ruby 3.0 back
  • added File.exist? (from File.exists?`)

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @agrare Please review.

@agrare agrare merged commit f8ee827 into ManageIQ:master Sep 24, 2024
6 checks passed
@kbrock kbrock deleted the untained_love branch September 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants