Replace images with icons in root nodes #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epwinchell Cannot apply the following label because they are not recognized: technical debt wip |
|
cc @skateman |
|
@miq-bot add_label technical debt, wip |
epwinchell
changed the title
|
@miq-bot rm_label wip |
|
@miq-bot add_label euwe/no |
skateman
reviewed
Jan 12, 2017
| node[:cfmeNoClick] = !leaf | ||
| node[:image] = image && ActionController::Base.helpers.image_path(image) | ||
| node[:icon] = image && ActionController::Base.helpers.image_path(image) |
There was a problem hiding this comment.
node[:icon] = leaf ? nil : "fa fa-tag"And remove line 8
|
Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/2ff74a90492e2b4035df5e49292450d8fcc85b94 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/129371557