[WIP] Allow to access saved report after associated task deleted #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yrudman Cannot apply the following label because they are not recognized: reporting |
yrudman
force-pushed
the
allow-to-access-report-after-task-deleted
branch
from
29fec63
to
9c6fad2
Compare
|
Checked commit yrudman@9c6fad2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
yrudman
changed the title
|
It seems ok, but all of What do you think @yrudman ? |
|
@martinpovolny agreed, I will move that logic to model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: UI controller did not allow access to report if report status not equal "complete" and if task deleted report's status(derived from task's status) was
undefinedBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1450272
Related PR: ManageIQ/manageiq#15134
@miq-bot add-label bug, reporting