Don't redact custom attributes #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laying" This reverts commit 5c64095 ( #844 ) In fine, custom attributes are used for proxy settings in some providers. This meant we needed to redact potentially sensitive usernames and passwords when displaying such custom attributes. For gaprindashvili, this will be moved to an `options` object on the manager ( ManageIQ/manageiq#15398 ), removing the need to redact these.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/f3cb9b1aed082d1d96811497e9b1d5aa7c307596 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Backend PR merged.. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq#15398
This reverts commit 5c64095 ( #844 )
In fine, custom attributes are used for proxy settings in some providers. This meant we needed to redact potentially sensitive usernames and passwords when displaying such custom attributes.
For gaprindashvili, this will be moved to an
optionsobject on the manager ( ManageIQ/manageiq#15398 ), removing the need to redact these.Removing..., this must be
fine/no.Cc @enoodle, @simon3z