Added changes to show Catalog Item type #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
show_catalog_item_type_on_screen
branch
from
c17d160
to
8b8b149
Compare
| @@ -111,7 +111,7 @@ def atomic_st_edit | |||
| @edit[:new] ||= {} | |||
| @edit[:current] ||= {} | |||
| @edit[:key] = "prov_edit__new" | |||
| @edit[:st_prov_types] = catalog_item_types | |||
There was a problem hiding this comment.
We should not be putting constants in the session. I cannot imagine a reason to do this.
There was a problem hiding this comment.
@martinpovolny moved constant out of session.
|
Looks good except for the in-line comment above. |
h-kataria
changed the title
Show nice display value for Catalog Item type in list view, Catalog Item detail view and as read only text on the add/edit screens. Moved list of catalog item types out of @edit hash, we can directly reference the constant from views. https://bugzilla.redhat.com/show_bug.cgi?id=1348239
h-kataria
force-pushed
the
show_catalog_item_type_on_screen
branch
from
8b8b149
to
faf9999
Compare
h-kataria
changed the title
|
Checked commit h-kataria@faf9999 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show Catalog ITem type of list view, Catalog Item detail view and as read only text on the add/edit screens
https://bugzilla.redhat.com/show_bug.cgi?id=1348239
@dclarizio please review, this PR depends on changes in core repo in ManageIQ/manageiq#13516
UI screenshots