-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional chargeback allocated calculation #1738
Optional chargeback allocated calculation #1738
Conversation
4a6865f
to
3571b4f
Compare
@@ -1295,6 +1299,7 @@ def set_form_vars | |||
|
|||
# @edit[:new][:cb_include_metrics] = nil - it means YES (YES is default value for new and legacy reports) | |||
@edit[:new][:cb_include_metrics] = options[:include_metrics].nil? || options[:include_metrics] | |||
@edit[:new][:method_for_allocated_metrics] = options[:method_for_allocated_metrics].try(:to_sym) || DEFAULT_CHARGEBACK_ALLOCATED_METHOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_()
needs to be applied to the values of the CHAREGEBACK_ALLOCATED_METHODS
hash for i18n
to really work here (same in the rest of this PR).
3571b4f
to
d37a04f
Compare
Checked commits lpichler/manageiq-ui-classic@f5a4bcc~...d37a04f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/report_controller/reports/editor.rb
app/helpers/ui_constants.rb
|
Adding the parameter to report definition to be able to select another method for chargeback calculation.
Links
cc @gtanzillo
@miq-bot assign @himdel
@miq_bot add_label enhancement