Add repository CRUD #346

ZitaNemeckova · 2017-02-10T12:03:51Z

New functionality for Repository in Automation -> Ansible -> Repositories.

Added Configuration button in toolbar with Add/Edit/Delete options.

Add form:

Edit form:

@miq-bot add_label wip

TODO:

h-kataria · 2017-03-23T21:50:18Z

@ZitaNemeckova validation message on URL field on form should show in Red, currently it is showing in grey text.

h-kataria · 2017-03-23T21:54:57Z

@ZitaNemeckova title header on the downloaded repo summary should say "Repository"

Title header on Edit repository form needs to be fixed too.

h-kataria · 2017-03-23T21:46:37Z

app/assets/javascripts/controllers/ansible_repository/repository_form_controller.js

+        message = __("Unable to add Repository ") +  vm.repositoryModel.name + " ." +  response.results[0].message;
+      }
+      else {
+        message = sprintf(__("Addition of Repository \"%s\" was successfully initialized."), vm.repositoryModel.name);


change this to "Add of ..." to make it consistent with other forms in UI

h-kataria · 2017-03-23T21:46:56Z

app/assets/javascripts/controllers/ansible_repository/repository_form_controller.js

+        message = __("Unable to update Repository") +  vm.repositoryModel.name + " ." +  response.message;
+      }
+      else {
+        message = sprintf(__("Update of Repository \"%s\" was successfully initialized."), vm.repositoryModel.name);


same here "Edit of ..." to be consistent

h-kataria · 2017-03-23T21:47:30Z

app/controllers/ansible_repository_controller.rb

+    AnsibleRepositoryController.model.where(:id => checked).each do |repo|
+      begin
+        repo.delete_in_provider_queue
+        add_flash(_("Deletion of Repository \"%{name}\" was successfully initiated.") % {:name => repo.name})


Change this to "Delete of ..."

h-kataria · 2017-03-23T21:47:56Z

app/assets/javascripts/controllers/ansible_repository/repository_form_controller.js

+  };
+
+  $scope.cancelClicked = function() {
+    var message = repositoryId === 'new' ? __("Addition of Repository canceled by user.") : sprintf(__("Addition of Repository \"%s\" canceled by user."), vm.repositoryModel.name)


this should be "Add of Repository cancelled by user." : "Edit of Repository "%s" cancelled by user."

h-kataria · 2017-03-23T21:51:46Z

app/views/ansible_repository/_repository_form.html.haml

+                     options_for_select([["#{_('GIT')}", "git"]], 'git'),
+                     "ng-model" => "vm.repositoryModel.scm_type",
+                     :disabled => true)
+    .form-group


I think you need to add a class here to get validation message to show in red color
.form-group{"ng-class" => "{'has-error': angularForm.scm_url.$invalid}"}

h-kataria · 2017-03-23T22:05:34Z

@ZitaNemeckova can you also address code climate errors, most of them look easy to address. I was successfully able to add/edit/delete repositories 👍

ZitaNemeckova · 2017-03-24T12:39:34Z

@h-kataria PDF issue addressed in ManageIQ/manageiq#14485

ZitaNemeckova · 2017-03-24T13:11:16Z

Codeclimate failures related to using $scope cannot be addressed as it has to be used to work with buttons. It will be removed once all controller has controllerAs. Avoid using a variable and instead use chaining with the getter syntax. other controllers have it this way. Similar code found in 3 other locations for $scope.cancelClicked cannot be de-duplicated.

ZitaNemeckova · 2017-03-24T16:41:12Z

@h-kataria I will add them in separate PR due to time pressure.

Url validation needed because default ng url validation was positive for any web protocol but it was needed to be positive only for http or https

gmcculloug · 2017-03-24T17:28:56Z

@jameswnl Please review. I think you are most familiar with this from the provider side.

himdel · 2017-03-24T17:41:35Z

app/views/ansible_repository/_repository_form.html.haml

+:javascript
+  ManageIQ.angular.app.value('repositoryId', '#{@id}');
+  miq_bootstrap('#form_div');
+  $("#form-div").submit(function (e) {


This is broken since you should never be submitting the form (old-style) .. Better to just put miqSparkleOn() in addClicked and saveClicked.

himdel · 2017-03-24T17:42:32Z

app/assets/javascripts/controllers/ansible_repository/repository_form_controller.js

+
+  $scope.addClicked = function() {
+    API.post('/api/configuration_script_sources/', vm.repositoryModel)
+       .then(getBack)


2 spaces, not three please

himdel · 2017-03-24T17:42:53Z

app/assets/javascripts/directives/url_validation.js

+      };
+
+      var validUrl = function(s) {
+        debugger;


wink wink, nudge nudge

himdel · 2017-03-24T18:00:45Z

(travis failure unrelated - gitter March 24, 2017 5:54 PM)

jameswnl · 2017-03-24T19:03:24Z

app/assets/javascripts/controllers/ansible_repository/repository_form_controller.js

+      scm_type: 'git',
+      manager_resource: {},
+      scm_url: '',
+      scm_credentials: null,


(Potentially a silly question as I am not familiar with UI code)
There can be 0 or 1 scm_credential associated with a repo/project. Here the pluralized form, does it mean multiple values expected? Or it is the list of values to be selected from?

@jameswnl there are no stupid questions :) I must have missed some change because scm_credentials no longer exists and there's authentication_id instead. Thanks :)

Wow, feel good to be useful in UI land 😄

ZitaNemeckova · 2017-03-27T14:40:18Z

@miq-bot remove_label wip

miq-bot · 2017-03-27T17:24:02Z

Checked commits ZitaNemeckova/manageiq-ui-classic@a727871~...b905166 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 9 offenses detected

app/helpers/application_helper/toolbar/ansible_repositories_center.rb

❗ - Line 14, Col 37 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
❗ - Line 22, Col 37 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
❗ - Line 31, Col 92 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
❗ - Line 34, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/ansible_repository_center.rb

❗ - Line 14, Col 26 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
❗ - Line 21, Col 92 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
❗ - Line 24, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

h-kataria · 2017-03-27T17:52:53Z

@ZitaNemeckova merging this PR, please add jasmine spec tests in an additional PR.

miq-bot added the wip label Feb 10, 2017

dclarizio added automation/ansible enhancement euwe/no labels Feb 14, 2017

chessbyte assigned dclarizio Feb 16, 2017

ZitaNemeckova mentioned this pull request Feb 23, 2017

Add Repository to miq_features ManageIQ/manageiq#14048

Merged

ZitaNemeckova force-pushed the repository_form branch 2 times, most recently from 6e1f411 to c34e516 Compare February 27, 2017 14:50

ZitaNemeckova force-pushed the repository_form branch 3 times, most recently from 37f074f to b1c1855 Compare March 8, 2017 13:43

ZitaNemeckova force-pushed the repository_form branch 4 times, most recently from 6ec2d67 to 52d1630 Compare March 21, 2017 13:03

ZitaNemeckova force-pushed the repository_form branch 2 times, most recently from fc47314 to d1aa247 Compare March 23, 2017 15:00

h-kataria suggested changes Mar 23, 2017

View reviewed changes

ZitaNemeckova mentioned this pull request Mar 24, 2017

Add missing ui_lookup for Repository ManageIQ/manageiq#14485

Merged

ZitaNemeckova force-pushed the repository_form branch 3 times, most recently from 487426f to adfae8a Compare March 24, 2017 12:54

ZitaNemeckova added 3 commits March 24, 2017 14:45

Add repository_form template and its js controller

a727871

More changes

64016db

More changes

4519dbc

ZitaNemeckova force-pushed the repository_form branch from e51eaa7 to 2b70bdd Compare March 24, 2017 16:37

ZitaNemeckova closed this Mar 24, 2017

ZitaNemeckova reopened this Mar 24, 2017

Fix typo and add url validation

3c4b3c4

Url validation needed because default ng url validation was positive for any web protocol but it was needed to be positive only for http or https

ZitaNemeckova force-pushed the repository_form branch from 2b70bdd to 3c4b3c4 Compare March 24, 2017 17:07

himdel reviewed Mar 24, 2017

View reviewed changes

app/assets/javascripts/directives/url_validation.js Outdated

};

var validUrl = function(s) {

debugger;

Copy link

Contributor

himdel Mar 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wink wink, nudge nudge

jameswnl reviewed Mar 24, 2017

View reviewed changes

ZitaNemeckova changed the title ~~[WIP] Add repository CRUD~~ Add repository CRUD Mar 27, 2017

miq-bot removed the wip label Mar 27, 2017

Fix adding credential to repository

1c965d1

ZitaNemeckova force-pushed the repository_form branch from 4a4c362 to 1c965d1 Compare March 27, 2017 14:49

ZitaNemeckova added 2 commits March 27, 2017 17:21

Add auth control to delete

d754205

Styling cleanup and error for non-existing embedded provider

42cee8f

ZitaNemeckova force-pushed the repository_form branch from c4bc261 to 42cee8f Compare March 27, 2017 16:13

Change API call to get only scm credentials

0682857

ZitaNemeckova force-pushed the repository_form branch from 14aafe3 to 0682857 Compare March 27, 2017 16:50

ZitaNemeckova added 2 commits March 27, 2017 19:10

Add name, pf-select and checkchange to dropdown

a44b77a

Don't redirect after failed add/save, I18N fix

b905166

h-kataria approved these changes Mar 27, 2017

View reviewed changes

h-kataria merged commit 9e406c0 into ManageIQ:master Mar 27, 2017

h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 27, 2017

ZitaNemeckova deleted the repository_form branch September 12, 2017 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add repository CRUD #346

Add repository CRUD #346

ZitaNemeckova commented Feb 10, 2017 •

edited

Loading

h-kataria commented Mar 23, 2017

h-kataria commented Mar 23, 2017 •

edited

Loading

h-kataria Mar 23, 2017

h-kataria Mar 23, 2017

h-kataria Mar 23, 2017

h-kataria Mar 23, 2017

h-kataria Mar 23, 2017

h-kataria commented Mar 23, 2017

ZitaNemeckova commented Mar 24, 2017

ZitaNemeckova commented Mar 24, 2017

ZitaNemeckova commented Mar 24, 2017

gmcculloug commented Mar 24, 2017

himdel Mar 24, 2017

himdel Mar 24, 2017

himdel Mar 24, 2017

himdel commented Mar 24, 2017

jameswnl Mar 24, 2017 •

edited

Loading

ZitaNemeckova Mar 27, 2017

jameswnl Mar 27, 2017

ZitaNemeckova commented Mar 27, 2017

miq-bot commented Mar 27, 2017

h-kataria commented Mar 27, 2017

Add repository CRUD #346

Add repository CRUD #346

Conversation

ZitaNemeckova commented Feb 10, 2017 • edited Loading

h-kataria commented Mar 23, 2017

h-kataria commented Mar 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h-kataria commented Mar 23, 2017

ZitaNemeckova commented Mar 24, 2017

ZitaNemeckova commented Mar 24, 2017

ZitaNemeckova commented Mar 24, 2017

gmcculloug commented Mar 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himdel commented Mar 24, 2017

jameswnl Mar 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZitaNemeckova commented Mar 27, 2017

miq-bot commented Mar 27, 2017

h-kataria commented Mar 27, 2017

ZitaNemeckova commented Feb 10, 2017 •

edited

Loading

h-kataria commented Mar 23, 2017 •

edited

Loading

jameswnl Mar 24, 2017 •

edited

Loading