Call changeAuthTab from more miq_tab_header()s

[cben]

https://bugzilla.redhat.com/show_bug.cgi?id=1434064 (master)
https://bugzilla.redhat.com/show_bug.cgi?id=1434096 (euwe)

miq_tab_header() once did this automatically.
That was disabled by 2b1da75 in #68 and explicit ng-click
was added to some tab headers but not all. This adds some more.

Should help some tabs in providers add/edit (e.g. containers Hawkular tab) and something dealing with hosts(?), not sure where that is but I see there is changeAuthTab function in host_form_controller.js so added it.

Alas, something still doesn't work and Hawkular tab [Verify] button is broken, there is probably something else going on...
@himdel @AparnaKarve Please review/test.

[miq-bot]

Checked commit cben@9137125 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 8 offenses detected

app/views/layouts/angular/_multi_auth_credentials.html.haml

• ⚠️ - Line 10 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 14 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 17 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 20 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 24 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 28 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 30 - Redundant curly braces around a hash parameter.
• ⚠️ - Line 32 - Redundant curly braces around a hash parameter.

[AparnaKarve]

@himdel It looks like #68 broke some angular functionality for us in forms that have tabs.

changeAuthTab does not trigger an apply/digest cycle anymore while changing tabs because the 'ng-click' => "changeAuthTab changes were applied in the wrong haml : app/views/layouts/_multi_auth_credentials.html.haml

Unfortunately, the PR was backported to darga and euwe, which means we are going to need a BZ here to undo the bug in #68 for darga and euwe.

[AparnaKarve]

@cben The changes look good.
But you'll also need changes to undo what was added in app/views/layouts/_multi_auth_credentials.html.haml in #68
Thanks.

[himdel]

@cben I'm confused.. the change I'm seeing in this PR is exactly the same I did in #68 , isn't it? https://github.com/ManageIQ/manageiq-ui-classic/pull/68/files#diff-bb8a7a7ffa5ad1f77d61eb03b111e361R9

Possibly more to the point, I'm seeing that file with all those ng-click on current master. What am I missing?

[himdel]

@AparnaKarve please don't undo anything, the change is exactly equivalent to before... But do tell me what's actually broken :).

EDIT: (Except in a completely different file O:-))

[himdel]

Aaah.. there's two different files called _multi_auth_credentials, and I've applied the change to the non-angular version instead of the angular version?

Ok, sorry about that, in that case, forget everything I said :D

[himdel]

Also @cben feel free to remove the other multi_auth_credentials. Seems like only the angular version is ever used...

[himdel]

But yes, this will have to be euwe/yes, darga/yes, because of #68.

[AparnaKarve]

Seems like only the angular version is ever used

True.
Besides ng-click is only an angular thing, and not applicable to the non-angular version of the haml.

[himdel]

Merged, removing the old one in #725

[himdel]

@cben I guess you'll need to find/create a BZ for this

[cben]

@simaishi BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434064
Tested darga & euwe, similar bug there — [Validate] buttons on all Endpoints reflect fields of main Endpoint (precise steps in BZ). Unlike master which also needed #713, this PR is enough for darga & euwe.
Hope you can backport this for today's 5.7 build...

[simaishi]

Euwe backport (to manageiq repo) details:

$ git log -1
commit a8a6fc41def7299bbe5dd3a3e90f6e13a811d70f
Author: Martin Hradil <[email protected]>
Date:   Fri Mar 17 13:13:17 2017 +0000

    Merge pull request #706 from cben/changeAuthTab
    
    Call changeAuthTab from more miq_tab_header()s
    (cherry picked from commit 48e62ed81ef51e156e2d883430d4f4c271d9138b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1434096

[simaishi]

Backported to Darga via ManageIQ/manageiq#14410