Update angular to 1.8.3 #9282
Merged
Update angular to 1.8.3 #9282
+18
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the goal to eventually upgrade angular patternfly in a future pr? |
As of right now I don't think so, this is the package upgrade that was causing issues for us that we couldn't figure out how to get from version 3 to 4, which is why we pinned lodash to version 4 directly. Unless we have someone who is very familiar with Angular this would be a very complicated upgrade to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated angular, angular-animate and angular-sanitize to 1.8.3. Due to angular-patternfly depending on angular, angular-animate and angular-sanitize I had to use the resolutions for these package upgrades since upgrading angular-patternfly breaks certain forms in the UI.