Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUI specific RBAC list #882

Closed
chriskacerguis opened this issue Aug 22, 2017 · 20 comments
Closed

SUI specific RBAC list #882

chriskacerguis opened this issue Aug 22, 2017 · 20 comments
Assignees

Comments

@chriskacerguis
Copy link
Contributor

chriskacerguis commented Aug 22, 2017

The current RBAC system feature list doesn't map well to the SUI; and in various chats with SUI parties we really need to expand the system, however that's going to take more time and resources (e.g. we will need Ops UI work to "control" the RBAC).

So, I'd like to propose the following:

  1. As we build out the new UX we "attach" a new "feature" to each and everything.
  2. We will build an abstraction layer which will "translate" the existing features to the new feature or features.
  3. We will adjust the abstraction layer once there are resources to tackle the necessary "backend" / Ops UI work.

Thoughts?

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1497728

@chriskacerguis
Copy link
Contributor Author

@dclarizio
Copy link

So, I'd like to propose the following:

  1. As we build out the new UX we "attach" a new "feature" to each and everything.

We can (and do) do this in existing RBAC, unless I don't fully understand.

  1. We will build an abstraction layer which will "translate" the existing features to the new feature or features.

This is because we want to try to keep using the OPS service features for SUI?

  1. We will adjust the abstraction layer once there are resources to tackle the necessary "backend" / Ops UI work.

Not sure what backend/OPS UI work you mean, adding the RBAC features? Because that's quite simple actually.

Another proposal . . . how about we simply make a Service UI section in the existing RBAC that more closely matches the features required there. If/when we remove the Service section from the OPS UI, we simply remove the old service related RBAC features.

@chriskacerguis
Copy link
Contributor Author

We can (and do) do this in existing RBAC, unless I don't fully understand.

So, what I mean is brand new feature "names" not trying to sledgehammer existing ones.

This is because we want to try to keep using the OPS service features for SUI?

I didn't want to create work that cannot be done this release for other teams.

Not sure what backend/OPS UI work you mean, adding the RBAC features? Because that's quite simple actually.

Yes, I wasn't sure how to add new features.

how about we simply make a Service UI section in the existing RBAC that more closely matches the features required there

That's what I would like to do in the long run, the abstraction layer was how do we get from where we are at today to a new set of features without creating lots of work outside the team.

@AllenBW
Copy link
Member

AllenBW commented Aug 22, 2017

Yes please to a UI/Service section in existing RBAC. This'll save the "guessing which feature does what in the service ui" for admins everywhere also make gating functionality easier for the devs (no more trying to map functionality against in place permissions). As in intermediary, an abstraction layer that maybe "bulk" maps functionality makes sense. Ultimately, who do we gotta see about gettin' some of of those product feature sections (or zones? not sure what the sub collections are called).

@dclarizio
Copy link

@AllenBW as long as we follow the pattern with the low level grouping, like having the View/Operate/Modify sub-trees so the admins can easily turn on sets of features, I see no reason not to add a new top level section called "Service UI" (feature ID sui). Perhaps all sub features below that will be sui_*. If we can map them all out, we can add them prior to adding the checks, since no one will be using them.

Let's get some feedback/buy in from PM . . . @Loicavenel @bascar @jonnyfiveiq

@jonnyfiveiq
Copy link

jonnyfiveiq commented Aug 24, 2017 via email

@Loicavenel
Copy link

@chriskacerguis chriskacerguis changed the title SUI specific feature list SUI specific RBAC list Sep 11, 2017
@chriskacerguis
Copy link
Contributor Author

@dclarizio or @martinpovolny or @himdel how do we add a new role / product feature?

/cc @chalettu @Loicavenel

@chriskacerguis chriskacerguis mentioned this issue Sep 25, 2017
6 tasks
@Loicavenel
Copy link

@chriskacerguis there are 2 things here, is to update Roles with SUI features like described here: https://docs.google.com/document/d/10p69nnTT7dG0hnCBCJkcapjlxVd08J0A2QRX054B_08/edit
And then or we create a new out-of-the-box Group + Role just for SUI or we update existing one

@dclarizio
Copy link

@chriskacerguis
Hey, we just went through this for the API section!

You gotta do this:
ManageIQ/manageiq#16021

and this:
ManageIQ/manageiq-ui-classic#2230

Let me or @h-kataria know if you need any assistance

@chriskacerguis
Copy link
Contributor Author

Thanks @dclarizio

@chriskacerguis
Copy link
Contributor Author

@chalettu so let's start with adding a "Self Service" top level, then for right now add the following:

  • Show Help Menu
  • Show UI Switcher

@chriskacerguis chriskacerguis assigned chalettu and unassigned AllenBW Sep 28, 2017
@Loicavenel
Copy link

@chriskacerguis Great..

@chalettu
Copy link
Contributor

PR For ManageIQ repo.
ManageIQ/manageiq#16068

@chalettu
Copy link
Contributor

PR for classic-ui modifications. ManageIQ/manageiq-ui-classic#2260

@chalettu
Copy link
Contributor

sui_features

Screen shot of new feature tree.

@Loicavenel
Copy link

@chriskacerguis For Help Menu, this was already for OPS UI.. We should use the same place.

@chriskacerguis
Copy link
Contributor Author

chriskacerguis commented Sep 29, 2017

So in talking with @chalettu we need to rework the RBAC module in the SUI.

@chalettu Wondering if we should make the RBAC module an NPM lib? Thoughts?

@chalettu
Copy link
Contributor

chalettu commented Oct 3, 2017

@chriskacerguis , should we close this since we now have the ability implemented where we can have RBAC permissions defined for SUI?

@chriskacerguis
Copy link
Contributor Author

@chalettu yeah, I was going to leave it open to rework the whole thing, but I think we should make a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants