Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created githash saving and display functionality #1003

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Created githash saving and display functionality #1003

merged 2 commits into from
Sep 25, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Sep 25, 2017 •
edited
Loading

This PR completes GH issue #999

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2017

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/9ef4bc35482a06a8e484323287a70abce563f455~...2876418849719c2fc18960b9ed881d0aa9270d14 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@chalettu
Copy link
Contributor Author

about
Screenshot of hash in action

@chalettu
Copy link
Contributor Author

@miq-bot add_label enhancement
@miq-bot add_label fine/no

@chriskacerguis chriskacerguis self-assigned this Sep 25, 2017
AllenBW
AllenBW approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dat sum goooood hash 😋

@chriskacerguis chriskacerguis added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 25, 2017
@chriskacerguis chriskacerguis merged commit 624133b into ManageIQ:master Sep 25, 2017
@chalettu chalettu deleted the git-hash branch January 10, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

@AllenBW AllenBW AllenBW approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @chriskacerguis @AllenBW