Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file-loader to the latest version 🚀 #1044

Merged
merged 2 commits into from
Oct 2, 2017

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Sep 29, 2017

Version 1.1.0 of file-loader just got published.

Dependency file-loader
Current Version 0.11.2
Type dependency

The version 1.1.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of file-loader.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes Release v1.1.0

1.1.0 (2017-09-29)

Features

  • add options validation (schema-utils) (#184) (696ca77)
Commits

The new version differs by 20 commits.

  • abe91a8 chore(release): 1.1.0
  • 696ca77 feat: add options validation (schema-utils) (#184)
  • 39016b8 docs(README): add missing commas in examples (#196)
  • e5c1c5e docs(README): fix typo 'placholder' (#195)
  • 68840b6 docs(README): add missing comma in example (#191)
  • 7e2998c docs(README): standardize (#171)
  • c5b205b chore: Update changelog for 1.0.0 final
  • 95e157b chore(release): 1.0.0
  • a9e6927 chore(release): 1.0.0-rc.0
  • 3fe2d12 fix: remove = from default export (SyntaxError) (#178)
  • b47224a chore(package): remove duplicate peerDependencies (#175)
  • aaf5f17 chore(package): add webpack peerDependency (#169)
  • 334cb98 chore: Update changelog
  • 450cf00 chore(release): 1.0.0-beta.1
  • acd6c2f chore: Update to defaults v.1.3.0 (#170)

There are 20 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@AllenBW
Copy link
Member

AllenBW commented Sep 29, 2017

@chriskacerguis So here's our issue,

We use url-loader to compress smaller font/images into data uris, awesome. You can limit the size until of the assets this loader will process and we do that to the tune of 20480 bytes, awesome. A file larger than that, by default gets then loaded by file-loader which has no option titled limit. Somehow url-loader is passing on these options (I think?) so we have a 3 choices

  1. remove the limit of url-loader
  2. remove url-loader, exclusively use file-loader
  3. fiddle around with url-loader and see if its a thing we can fix

the choice is yours

@chriskacerguis
Copy link
Contributor

I’m leaning towards option #2. The URL loader seems to keep causing issues (not a lot of times, but enough). Thoughts?

greenkeeper bot added a commit that referenced this pull request Sep 30, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 30, 2017

Version 1.1.1 just got published.

Update to this version instead 🚀

Release Notes Release v1.1.1

1.1.1 (2017-09-30)

Bug Fixes

Commits

The new version differs by 3 commits.

  • 0c52ae2 chore(release): 1.1.1
  • b46c2b8 chore: Update lock file
  • cf7c85a fix(schema): allow additionalProperties (#207)

See the full diff

greenkeeper bot added a commit that referenced this pull request Sep 30, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 30, 2017

Version 1.1.2 just got published.

Update to this version instead 🚀

Release Notes Release v1.1.2

1.1.2 (2017-09-30)

Bug Fixes

Commits

The new version differs by 2 commits.

  • 4e55bcc chore(release): 1.1.2
  • daeff0e fix(cjs): export raw value (#183)

See the full diff

greenkeeper bot added a commit that referenced this pull request Sep 30, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 30, 2017

Version 1.1.3 just got published.

Update to this version instead 🚀

Release Notes v1.1.3

2017-09-30

Commits

The new version differs by 2 commits.

  • c49aceb chore(release): 1.1.3
  • 5331946 build: Adds options.json to dist package

See the full diff

greenkeeper bot added a commit that referenced this pull request Sep 30, 2017
@greenkeeper
Copy link
Author

greenkeeper bot commented Sep 30, 2017

Version 1.1.4 just got published.

Update to this version instead 🚀

Release Notes Release v1.1.4

1.1.4 (2017-09-30)

Bug Fixes

Commits

The new version differs by 2 commits.

  • 8782cf1 chore(release): 1.1.4
  • f412b3e fix(index): revert to CJS exports (#212)

See the full diff

@AllenBW AllenBW force-pushed the greenkeeper/file-loader-1.1.0 branch from d579131 to 19588fa Compare October 2, 2017 11:18
@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2017

Checked commits f34560f~...19588fa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@AllenBW
Copy link
Member

AllenBW commented Oct 2, 2017

@chriskacerguis looks like they fixed their bug, in favor of leaving it for now

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built app looks good, down for this to get in.

@AllenBW AllenBW merged commit fd72431 into master Oct 2, 2017
@AllenBW AllenBW deleted the greenkeeper/file-loader-1.1.0 branch October 2, 2017 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants