Added RBAC to App Launcher #1046
Conversation
| @@ -64,6 +64,7 @@ export function NavigationController (Text, Navigation, Session, API_BASE, Shopp | |||
| about: RBAC.has('about'), | |||
| documentation: RBAC.has('documentation') | |||
| }, | |||
| appLauncher: RBAC.has('sui_app_launcher'), | |||
There was a problem hiding this comment.
:ducks: don't hate me, any way we can change vm.permissions.appLauncher to vm.permissions.suiAppLauncher or vm.permissions.sui_app_launcher
I have this feelin' down in my 🍖 that one day we'll thank ourselves for being redic explicit... as in... there won't be any way that conditional rendering can be confused with anything other than rbac.
ALSO looks to be that all the rback we'll be using going forward will lead off with sui so thinking carrying that onwards will also help future us...
|
Checked commits https://github.com/chalettu/manageiq-ui-service/compare/03e0fa8b19a3c2742ceb4281c3f5c9999b049521~...eafa9ee509fc4c73ab912efdbfa785828e3859b9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
No UX changes here; just adding RBAC. |
@miq-bot add_label enhancement
@miq-bot add_label fine/no