Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1498984-DB/LDAP User is not able to log into SSUI #1061

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Oct 6, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1498984

Reconfigure unsuccessful login attempt to purge user session
Delete X-Miq-Group header when purging session

But show me the bulk goods 💐

ldap

@AllenBW AllenBW added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 6, 2017
@chriskacerguis chriskacerguis self-assigned this Oct 6, 2017
@chriskacerguis
Copy link
Contributor

@AllenBW build fail. Also, can you please add some tests (or improve what exists) :)

Delete X-Miq-Group header when purging session
@miq-bot
Copy link
Member

miq-bot commented Oct 6, 2017

Checked commit AllenBW@f1e54f6 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Contributor

@chalettu chalettu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriskacerguis chriskacerguis merged commit 91b3a7f into ManageIQ:master Oct 6, 2017
@AllenBW AllenBW deleted the BZ/1498984-ldap-user-login branch October 6, 2017 16:38
@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2017

@AllenBW Can you please create a separate PR for Fine branch? Cherry-pick isn't clean and the conflict is rather big, so it's better that conflict is resolved by you.. Thanks.

@AllenBW
Copy link
Member Author

AllenBW commented Oct 9, 2017

yes @simaishi this thing will be done!

@simaishi
Copy link
Contributor

Backported to Fine via #1065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants