BZ#1503287-Ensure we only fetch those services with display set to true #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh yeah, i'll fix that |
AllenBW
force-pushed
the
BZ/1503287-services-filter-display-true
branch
2 times, most recently
from
54dbc91
to
74d9bbe
Compare
AllenBW
force-pushed
the
BZ/1503287-services-filter-display-true
branch
from
74d9bbe
to
06a6001
Compare
|
Checked commit AllenBW@06a6001 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1503287
So the bz points out we don't filter services based on display, best place to do it is in the request, otherwise the pagination will get wacky (imagine, fetching first 20 services and if 18 of them were display none!!)