clear user name field on failed login #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on discussion on a similar PR on the ops UI (ManageIQ/manageiq-ui-classic#2514 (comment)) I'm suggesting we align across the two.
|
Checked commit ohadlevy@cfa68cc with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I expressed this same sentiment in this comment here, #1142 (comment) Defer to @chriskacerguis on this |
|
I think that alignment is good. That said, the RFE was for the password only. Perhaps in the future, we should be aligned in the BZ/RFE before code starts? |
chriskacerguis
approved these changes
Oct 26, 2017
|
thanks @chriskacerguis - as a follow up - what is the correct way to write a test for this? (as a user i would expect the form user field to be empty)? |
|
@ohadlevy I think for a solid test for this, we need to turn Sauce Labs back on. We turned it off b/c the free version we were using took too long to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on discussion on a similar PR on the ops UI (ManageIQ/manageiq-ui-classic#2514 (comment))
I'm suggesting we align across the two.
I would also appericiate help in how to test the fact
the field is actually empty.