BUG#1171-Resource and menu action buttons on the same row #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pf-list-view has provisions for both menu (kebab) and action buttons, opting for our proven in place solution for fear the pf implementation will be a regression in terms of customizability These two classes create an experience identical to the component options without sacraficing functioning in place code
AllenBW
force-pushed
the
bug/#1171-service-details-resource-rows
branch
from
0660a19
to
7f8b47b
Compare
|
Checked commit AllenBW@7f8b47b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Oct 27, 2017
|
LGTM, waiting for UXD review from @serenamarie125 |
|
@serenamarie125 does this match what was discussed at the meeting? |
|
@Loicavenel this work for you? |
|
yes, this is what was in 4.5, back to normal |
|
Awesome, thanks @Loicavenel just waiting for @serenamarie125 sign off. |
|
Spacing looks off, but I can open an issue re: spacing |
|
@miq-bot add_labels ux/approved |
|
@miq-bot remove_labels ux/review |
serenamarie125
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1171
pf-list-view has provisions for both menu (kebab) and action buttons, opting for our proven in place solution for fear the pf implementation will be a regression in terms of customizability
These two classes create an experience identical to the component options without sacrificing functioning in place code