Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1512721-Use correct storage attribute, use metrics from last hour (not present) #1237

Merged
merged 3 commits into from
Nov 14, 2017
Merged

BZ#1512721-Use correct storage attribute, use metrics from last hour (not present) #1237

merged 3 commits into from
Nov 14, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Nov 14, 2017 •
edited
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1512721

Position 0 has metrics from current hour, position 1 has metrics from last hour, current hour does not report anything useful 😭

hey look, it works, all we had to do was change a 0 to a 1 🤦‍♂️

screen shot 2017-11-13 at 7 36 04 pm

@AllenBW AllenBW added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 14, 2017
@AllenBW AllenBW changed the title BZ#1512721-Use correct storage attribute, use metrics from last hour (not present) [WIP]BZ#1512721-Use correct storage attribute, use metrics from last hour (not present) Nov 14, 2017
@AllenBW
Use correct storage attribute, use metrics from last hour (not present)
71b4b98 
Position 0 has metrics from current hour, position 1 has metrics from last hour, current hour does not report anything useful 😭
@AllenBW
Ensure bytes to gb service returns a number
f26f719
@AllenBW
Refactor graph component to break less
4fc9a01 
Switching from assuming true to assuming false, ensures we don't throw erros running calculations on values that don't exist
@AllenBW AllenBW force-pushed the BZ/MASTER/#1512721-util-chart-refresh branch from f343efd to 4fc9a01 Compare November 14, 2017 01:11
@AllenBW AllenBW changed the title [WIP]BZ#1512721-Use correct storage attribute, use metrics from last hour (not present) BZ#1512721-Use correct storage attribute, use metrics from last hour (not present) Nov 14, 2017
@AllenBW AllenBW removed the wip label Nov 14, 2017
@chriskacerguis chriskacerguis self-assigned this Nov 14, 2017
@chriskacerguis chriskacerguis merged commit ea753f3 into ManageIQ:master Nov 14, 2017
@AllenBW AllenBW deleted the BZ/MASTER/#1512721-util-chart-refresh branch November 14, 2017 03:10
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@chriskacerguis @simaishi
Merge pull request #1237 from AllenBW/BZ/MASTER/#1512721-util-chart-r…
9fcf2b7 
…efresh

BZ#1512721-Use correct storage attribute, use metrics from last hour (not present)
(cherry picked from commit ea753f3)

https://bugzilla.redhat.com/show_bug.cgi?id=1513495
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 9fcf2b7bab91dfe27309791919c83847e1e68ffe
Author: Chris Kacerguis <[email protected]>
Date:   Mon Nov 13 20:46:55 2017 -0600

    Merge pull request #1237 from AllenBW/BZ/MASTER/#1512721-util-chart-refresh
    
    BZ#1512721-Use correct storage attribute, use metrics from last hour (not present)
    (cherry picked from commit ea753f328383ea54e47ca7dbeac2b409d00b0a81)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllenBW @simaishi @chriskacerguis