Changed where Generic objects list gets rendered on Service details screen #1246

chalettu · 2017-11-16T18:43:36Z

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1515945

chalettu · 2017-11-16T18:44:21Z

Sample screenshot of fix. This ensures that even if no VM's exist that we show Generic Objects on a service.

chalettu · 2017-11-16T18:45:03Z

@Loicavenel and @bascar . Could you take a look at this and see if update looks as you are expecting it to.

chriskacerguis · 2017-11-16T18:45:48Z

@Loicavenel @bascar need approval on this one. It does change the UX a bit, so @serenamarie125 could you please let us know if that is ok?

AllenBW · 2017-11-16T18:50:18Z

client/app/services/service-details/service-details.html

        </div>
    </div>
-
+    <div ng-if="vm.genericObjects.length > 0">


<div ng-if="vm.genericObjects.length">
will be true when anything is greater than 0

AllenBW · 2017-11-16T18:51:58Z

client/app/services/service-details/service-details.html

            </section>
+


eeeekkkk if we don't need da space...

AllenBW · 2017-11-16T18:54:56Z

@chalettu might not be a bad idea to give this area a header kinda similar "Properties" and "Resources" ?

Edit: or maybe if this lives inside of resources, something like "compute"?

chalettu · 2017-11-16T19:14:21Z

Ok, updated the screenshot to put this under the Resources section. It will show even in instances when no VM's exist for a service.

AllenBW · 2017-11-16T19:22:14Z

@chalettu oh gosh you're gonna 🔪 me, from the most recent ss, looks like the horizontal bars under above and below resources went away? or maybe my 👁 deceives me...

chalettu · 2017-11-16T19:24:01Z

They are still there. They are so light its hard to see. If you view the video full screen you should see em.

AllenBW · 2017-11-16T19:26:53Z

Yeah viewed it full screen... seem em around relationships just not resources... 🤔

AllenBW

Code checks out, LG2M 👍 💃

chalettu · 2017-11-16T19:29:58Z

You can see them in this image. They are a little lighter than those other line used by relationships, but that wasn't a change made in this PR. I merely moved a few things around so that GO's show up in the instance no other resources are defined.

serenamarie125

@chalettu, the Resources title is missing in some of the images. Sorry, I need to catchup on these comments. Looks like the mock is updated later.

Is there a before and after screenshot?

chalettu · 2017-11-20T19:36:25Z

@serenamarie125 , please disregard the earlier images. The very last one is the one we implemented and that one does show things being grouped appropriately under the Resources Title.

chriskacerguis · 2017-11-29T14:44:50Z

@chalettu is this ready to go for @serenamarie125 to review?

serenamarie125

@chalettu the number of objects of that generic type should be in parentheses ...
so in this example km-demo (2)

I know that's part of the design for all resources, although I'm not sure that it's already been implemented for VMs too

AllenBW · 2017-12-04T15:02:58Z

@chalettu Any update on implementing the requested changes?

chalettu · 2017-12-04T15:52:08Z

@AllenBW , code is all set for this PR , I was working on getting onto an appliance so I do a screenshot demo of the requested addition. I will double check with Loic to see if we have a appliance to use.

chalettu · 2017-12-04T16:47:50Z

Screenshot showing the updated count header for Generic Object types.

miq-bot · 2017-12-04T17:53:09Z

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/1cb64e0e8718feaad1a0b6e22655cfd3bb091e4d~...f95d7145e4ab8f331029622b7ed5a543d1a31336 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

chalettu · 2017-12-04T18:40:23Z

@serenamarie125 , can you take a quick look at the updated screen that includes the count of Genric objects? Thanks in advance.

serenamarie125 · 2017-12-07T17:41:24Z

Location of Generic Objects is 👍 and thanks for adding the count!

serenamarie125

Changes associated with the scope of this PR look good!

Side Note - unsure if generic object icons are being displayed programmatically or not. If not, we should create an additional issue @chalettu

serenamarie125 · 2017-12-07T17:44:40Z

@miq-bot add_label ux/approved

serenamarie125 · 2017-12-07T17:44:49Z

@miq-bot remove_label ux/review

AllenBW

LG2M 🌮 💃

Changed where Generic objects list gets rendered on Service details screen (cherry picked from commit 32ca812) https://bugzilla.redhat.com/show_bug.cgi?id=1524721

simaishi · 2017-12-11T22:05:10Z

Gaprindashvili backport details:

$ git log -1
commit 995ee638a89426fa08d4d18252813e9d7d0f3742
Author: Allen Wight <[email protected]>
Date:   Thu Dec 7 12:48:41 2017 -0500

    Merge pull request #1246 from chalettu/Generic-objects-list
    
    Changed where Generic objects list gets rendered on Service details screen
    (cherry picked from commit 32ca812a162cf49bbb43c72b0fe931af86bde3cb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524721

chalettu requested review from AllenBW and chriskacerguis as code owners November 16, 2017 18:43

miq-bot added bug gaprindashvili/yes labels Nov 16, 2017

chriskacerguis self-assigned this Nov 16, 2017

chriskacerguis added the ux/review label Nov 16, 2017

AllenBW reviewed Nov 16, 2017

View reviewed changes

client/app/services/service-details/service-details.html Outdated

</section>

Copy link

Member

AllenBW Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeeekkkk if we don't need da space...

AllenBW approved these changes Nov 16, 2017

View reviewed changes

serenamarie125 reviewed Nov 20, 2017

View reviewed changes

chriskacerguis previously approved these changes Nov 27, 2017

View reviewed changes

AllenBW previously approved these changes Nov 29, 2017

View reviewed changes

serenamarie125 suggested changes Nov 30, 2017

View reviewed changes

chalettu dismissed stale reviews from AllenBW and chriskacerguis via 6de3e44 November 30, 2017 16:20

AllenBW assigned AllenBW and unassigned chriskacerguis Dec 4, 2017

chalettu changed the title ~~Changed where Generic objects list gets rendered on Service detials screen~~ Changed where Generic objects list gets rendered on Service details screen Dec 4, 2017

chalettu added 5 commits December 4, 2017 10:48

Changed where Generic objects list gets rendered on screen.

1cb64e0

Updated based on PR feedback

44ba9d9

Updated how the Generic Objects are grouped under Resources

7570a6d

Added Object count to Generic Objects

9d73837

Updated how the generic objects list is counted

f95d714

serenamarie125 approved these changes Dec 7, 2017

View reviewed changes

miq-bot added ux/approved and removed ux/review labels Dec 7, 2017

AllenBW approved these changes Dec 7, 2017

View reviewed changes

AllenBW merged commit 32ca812 into ManageIQ:master Dec 7, 2017

AllenBW deleted the Generic-objects-list branch December 7, 2017 17:48

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Dec 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed where Generic objects list gets rendered on Service details screen #1246

Changed where Generic objects list gets rendered on Service details screen #1246

chalettu commented Nov 16, 2017 •

edited by chriskacerguis

Loading

chalettu commented Nov 16, 2017

chalettu commented Nov 16, 2017

chriskacerguis commented Nov 16, 2017

AllenBW Nov 16, 2017

AllenBW Nov 16, 2017

AllenBW commented Nov 16, 2017 •

edited

Loading

chalettu commented Nov 16, 2017

AllenBW commented Nov 16, 2017

chalettu commented Nov 16, 2017

AllenBW commented Nov 16, 2017

AllenBW left a comment

chalettu commented Nov 16, 2017

serenamarie125 left a comment •

edited

Loading

chalettu commented Nov 20, 2017

chriskacerguis commented Nov 29, 2017

serenamarie125 left a comment

AllenBW commented Dec 4, 2017

chalettu commented Dec 4, 2017

chalettu commented Dec 4, 2017

miq-bot commented Dec 4, 2017

chalettu commented Dec 4, 2017

serenamarie125 commented Dec 7, 2017

serenamarie125 left a comment

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

AllenBW left a comment

simaishi commented Dec 11, 2017

Changed where Generic objects list gets rendered on Service details screen #1246

Changed where Generic objects list gets rendered on Service details screen #1246

Conversation

chalettu commented Nov 16, 2017 • edited by chriskacerguis Loading

chalettu commented Nov 16, 2017

chalettu commented Nov 16, 2017

chriskacerguis commented Nov 16, 2017

AllenBW Nov 16, 2017

Choose a reason for hiding this comment

AllenBW Nov 16, 2017

Choose a reason for hiding this comment

AllenBW commented Nov 16, 2017 • edited Loading

chalettu commented Nov 16, 2017

AllenBW commented Nov 16, 2017

chalettu commented Nov 16, 2017

AllenBW commented Nov 16, 2017

AllenBW left a comment

Choose a reason for hiding this comment

chalettu commented Nov 16, 2017

serenamarie125 left a comment • edited Loading

Choose a reason for hiding this comment

chalettu commented Nov 20, 2017

chriskacerguis commented Nov 29, 2017

serenamarie125 left a comment

Choose a reason for hiding this comment

AllenBW commented Dec 4, 2017

chalettu commented Dec 4, 2017

chalettu commented Dec 4, 2017

miq-bot commented Dec 4, 2017

chalettu commented Dec 4, 2017

serenamarie125 commented Dec 7, 2017

serenamarie125 left a comment

Choose a reason for hiding this comment

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

AllenBW left a comment

Choose a reason for hiding this comment

simaishi commented Dec 11, 2017

chalettu commented Nov 16, 2017 •

edited by chriskacerguis

Loading

AllenBW commented Nov 16, 2017 •

edited

Loading

serenamarie125 left a comment •

edited

Loading