Added custom button menu to Resource Details page #1254

chalettu · 2017-11-17T17:09:35Z

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label enhancement
BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1513113

chalettu · 2017-11-17T17:19:30Z

Before SS

chalettu · 2017-11-17T17:19:45Z

After SS

Loicavenel · 2017-11-17T18:40:35Z

@AllenBW I am confused here. the design if I am not mistaking is to have the kebab menu when there are too many Custom button on the top bar not all the time...

Loicavenel · 2017-11-17T18:40:53Z

@serenamarie125 need your comment here..

chalettu · 2017-11-17T18:42:37Z

@Loicavenel , no need to ask @AllenBW , I was the one working on this issue. This kebab menu will not show all the time, we put a limit of 3 custom buttons or button groups to show on the screen before we show the kebab menu instead. This limit can be programmatically adjusted we just wanted to start with an implementation that would prevent button overflow on the screen.

Loicavenel · 2017-11-17T18:47:50Z

@chalettu my apologise..

chalettu · 2017-11-17T18:49:25Z

No worries @Loicavenel . Screenshots and small videos can sometimes make it hard to convey other logic behind what is intended.

chriskacerguis · 2017-11-17T19:06:42Z

@chalettu could you please address the CC issues?

@Loicavenel I think what @chalettu is showing is that it is limiting the buttons now (it's not all the time)...at least that is not what the desired behavior is. @chalettu could you clarify?

serenamarie125

@chalettu spacing between buttons is an issue. I think I have another Issue about this, but can't find it now.
Questions:

what is "SS" ??? The custom button group should be shown on the toolbar in this case, I'm a bit confused
why is there a tooltip on each of the menu items?

chalettu · 2017-11-20T19:35:13Z

@serenamarie125 , I agree that button spacing is an issue. Chris K had created another issue to address it for clarity sake and being consistent.
SS is just an abbreviation for screen shot. So the screenshots are for demo purposes. The code as implemented will only default to kebab menu after 3 buttons/button groups are defined. We can change this count if you like.
The tooltips are aren't necessary and we can remove them if you feel they don't fit for that drop down. Please let me know and we can definitely have them removed.

serenamarie125 · 2017-11-20T21:57:39Z

LOL - i'm being too literal sorry @chalettu now i get the "SS"

tooltips are fine, @Loicavenel just showed me that you can set hover text, so that makes sense.

I do see an issue that the drop down menu has a caret at the top ... it should be straight, similar to the user menu shown below

chalettu · 2017-11-20T22:46:04Z

@serenamarie125 , Here is a SS with the caret removed. Please let me know if we think any more changes might be required.

serenamarie125 · 2017-11-21T01:14:22Z

@chalettu this is really more complex :\

Kebab uses caret (http://www.patternfly.org/pattern-library/widgets/#kebabs)

note that the kebab has a selected state and the caret should be centered - this screenshot is from the code example from the link above

The regular menus ( snapshots & power operations) shouldn't

AllenBW · 2017-12-04T14:53:07Z

@chalettu Any update on centering of the kebab dropdown ?

chalettu · 2017-12-04T15:55:38Z

@AllenBW , haven't come back to this one. I will try and take a look at centering the kebab.

AllenBW · 2017-12-04T19:29:58Z

@chalettu I suspect this might be a less is more kinda situation... rip out classes see what changes... 🤔

Also updated how buttons and button groups are collectively calculated

chalettu · 2017-12-06T20:17:57Z

Updated SS where I added back the caret and centered it.

chalettu · 2017-12-06T20:27:24Z

@serenamarie125 , can you take a look at this latest screenshot and see if it matches your expectations of this caret menu?

serenamarie125

perfect @chalettu thank you!

serenamarie125 · 2017-12-07T16:15:38Z

@miq-bot add_labels ux/approved

serenamarie125 · 2017-12-07T16:15:50Z

@miq-bot remove_labels ux/review

serenamarie125 · 2017-12-07T16:16:56Z

@miq-bot add_label ux/approved

serenamarie125 · 2017-12-07T16:17:06Z

@miq-bot remove_label ux/review

AllenBW

@chalettu ok just the one thing, ONE THING then this is g2g 🙇 ❤️

AllenBW · 2017-12-07T16:55:54Z

client/app/services/custom-button-menu/custom-button-menu.component.js

+      }
+    }
+
+    function postFailure () {


There's gonna be real valuable server feedback on the error here, something similar to this should be used here

miq-bot · 2017-12-07T22:38:55Z

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/7f09ef9d7c5909f5ec50565db7c14b84b57362a9~...24ad37e28fdda13f3dc3b30efb81ad1336742441 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

chalettu · 2017-12-07T22:54:14Z

@AllenBW , I updated based on feedback. Let me know if you approve.

AllenBW

Looks delicious 😋 thanks for updating!!

Added custom button menu to Resource Details page (cherry picked from commit 672d128) https://bugzilla.redhat.com/show_bug.cgi?id=1524718

simaishi · 2017-12-11T21:56:20Z

Gaprindashvili backport details:

$ git log -1
commit 0b8e5730075e7feead9d824be159191f2124679a
Author: Allen Wight <[email protected]>
Date:   Fri Dec 8 07:10:47 2017 -0500

    Merge pull request #1254 from chalettu/custom-button-grouping
    
    Added custom button menu to Resource Details page
    (cherry picked from commit 672d1281341c8e7f818d1779682679e9727abfa4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1524718

chalettu requested review from AllenBW and chriskacerguis as code owners November 17, 2017 17:09

miq-bot added gaprindashvili/yes enhancement labels Nov 17, 2017

chriskacerguis self-assigned this Nov 17, 2017

chriskacerguis added ux/review bug and removed enhancement labels Nov 18, 2017

serenamarie125 reviewed Nov 20, 2017

View reviewed changes

AllenBW assigned ohadlevy and unassigned chriskacerguis Dec 4, 2017

miq-bot added the enhancement label Dec 4, 2017

AllenBW assigned AllenBW and unassigned ohadlevy Dec 4, 2017

Added custom button menu to Resource Details page

7f09ef9

chalettu added 3 commits December 6, 2017 12:31

Removed EventNotifications from test definition

a4af29c

Updated test to simplify execution

0b49051

Removed Caret from menu

24450c6

Also updated how buttons and button groups are collectively calculated

chalettu requested a review from himdel as a code owner December 6, 2017 19:32

Readded Caret menu and centered caret

b522608

serenamarie125 approved these changes Dec 7, 2017

View reviewed changes

miq-bot added ux/approved and removed ux/review labels Dec 7, 2017

AllenBW added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 7, 2017

AllenBW suggested changes Dec 7, 2017

View reviewed changes

chalettu added 2 commits December 7, 2017 15:21

Updated error response message

f2cbf6a

Removed semicolon

24ad37e

AllenBW approved these changes Dec 8, 2017

View reviewed changes

AllenBW merged commit 672d128 into ManageIQ:master Dec 8, 2017

AllenBW deleted the custom-button-grouping branch December 8, 2017 12:10

chalettu mentioned this pull request Dec 8, 2017

Fixed issue with custom button groups #1334

Merged

simaishi pushed a commit that referenced this pull request Dec 11, 2017

Merge pull request #1254 from chalettu/custom-button-grouping

0b8e573

Added custom button menu to Resource Details page (cherry picked from commit 672d128) https://bugzilla.redhat.com/show_bug.cgi?id=1524718

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Dec 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added custom button menu to Resource Details page #1254

Added custom button menu to Resource Details page #1254

chalettu commented Nov 17, 2017

chalettu commented Nov 17, 2017

chalettu commented Nov 17, 2017

Loicavenel commented Nov 17, 2017

Loicavenel commented Nov 17, 2017

chalettu commented Nov 17, 2017 •

edited

Loading

Loicavenel commented Nov 17, 2017

chalettu commented Nov 17, 2017

chriskacerguis commented Nov 17, 2017 •

edited

Loading

serenamarie125 left a comment

chalettu commented Nov 20, 2017

serenamarie125 commented Nov 20, 2017

chalettu commented Nov 20, 2017

serenamarie125 commented Nov 21, 2017

AllenBW commented Dec 4, 2017

chalettu commented Dec 4, 2017

AllenBW commented Dec 4, 2017

chalettu commented Dec 6, 2017

chalettu commented Dec 6, 2017

serenamarie125 left a comment

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

AllenBW left a comment

AllenBW Dec 7, 2017

miq-bot commented Dec 7, 2017

chalettu commented Dec 7, 2017

AllenBW left a comment

simaishi commented Dec 11, 2017

Added custom button menu to Resource Details page #1254

Added custom button menu to Resource Details page #1254

Conversation

chalettu commented Nov 17, 2017

chalettu commented Nov 17, 2017

chalettu commented Nov 17, 2017

Loicavenel commented Nov 17, 2017

Loicavenel commented Nov 17, 2017

chalettu commented Nov 17, 2017 • edited Loading

Loicavenel commented Nov 17, 2017

chalettu commented Nov 17, 2017

chriskacerguis commented Nov 17, 2017 • edited Loading

serenamarie125 left a comment

Choose a reason for hiding this comment

chalettu commented Nov 20, 2017

serenamarie125 commented Nov 20, 2017

chalettu commented Nov 20, 2017

serenamarie125 commented Nov 21, 2017

AllenBW commented Dec 4, 2017

chalettu commented Dec 4, 2017

AllenBW commented Dec 4, 2017

chalettu commented Dec 6, 2017

chalettu commented Dec 6, 2017

serenamarie125 left a comment

Choose a reason for hiding this comment

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

serenamarie125 commented Dec 7, 2017

AllenBW left a comment

Choose a reason for hiding this comment

AllenBW Dec 7, 2017

Choose a reason for hiding this comment

miq-bot commented Dec 7, 2017

chalettu commented Dec 7, 2017

AllenBW left a comment

Choose a reason for hiding this comment

simaishi commented Dec 11, 2017

chalettu commented Nov 17, 2017 •

edited

Loading

chriskacerguis commented Nov 17, 2017 •

edited

Loading