Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1516430-Ensure the correct ansible play elapsed time is displayed #1326

Merged
merged 2 commits into from
Dec 12, 2017
Merged

BZ#1516430-Ensure the correct ansible play elapsed time is displayed #1326

merged 2 commits into from
Dec 12, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Dec 7, 2017 •
edited
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1516430

WOOP WOOP see, look now they're all the same

screen shot 2017-12-07 at 1 56 47 pm

@AllenBW AllenBW requested a review from himdel as a code owner December 7, 2017 18:58
@AllenBW AllenBW added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 7, 2017
@himdel
Copy link
Contributor

himdel commented Dec 7, 2017

@AllenBW LGTM, but the exact same bug is also present in client/app/services/resource-details/resource-details.component.js .. care to fix both? :)

@AllenBW
Copy link
Member Author

AllenBW commented Dec 7, 2017

@himdel it has been done, NICE CATCH 🙇‍♀️

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2017

Checked commits AllenBW/manageiq-ui-service@b4f27d0~...6f8774b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

himdel
himdel approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himdel himdel merged commit 22f27c1 into ManageIQ:master Dec 12, 2017
simaishi pushed a commit that referenced this pull request Dec 12, 2017
@himdel @simaishi
Merge pull request #1326 from AllenBW/bug/master/#1516430-incorrect-e…
8f902a5 
…lapsed-play-calculation

BZ#1516430-Ensure the correct ansible play elapsed time is displayed
(cherry picked from commit 22f27c1)

https://bugzilla.redhat.com/show_bug.cgi?id=1525079
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 8f902a54f3693b9ed3a71317fc55f22e8d92fe2d
Author: Martin Hradil <[email protected]>
Date:   Tue Dec 12 13:26:33 2017 +0000

    Merge pull request #1326 from AllenBW/bug/master/#1516430-incorrect-elapsed-play-calculation
    
    BZ#1516430-Ensure the correct ansible play elapsed time is displayed
    (cherry picked from commit 22f27c12e3be47e2202d476963f41a0b19a44aa7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1525079

@AllenBW AllenBW deleted the bug/master/#1516430-incorrect-elapsed-play-calculation branch December 12, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees

@himdel himdel

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AllenBW @himdel @miq-bot @simaishi