BZ#1525880-Ensure service tag filters flagged for translation #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenBW
changed the title
|
Checked commit AllenBW@0894bf3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
AFAIK the only option is to create a patternfly PR to allow passing in those strings to override their default ones. (Which sometimes means we have to temporrarily copy the component out of PF to be able to backport.) |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
…d-filter-text BZ#1525880-Ensure service tag filters flagged for translation (cherry picked from commit 27c851f)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://bugzilla.redhat.com/show_bug.cgi?id=1525880
The "results" and "selected text sadly aren't within our control, provided by ang-pf, looking into possible options for translating...