Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1518056-Ensured tooltips do not show when drop downs are open #1345

Merged
merged 1 commit into from
Dec 15, 2017
Merged

BZ#1518056-Ensured tooltips do not show when drop downs are open #1345

merged 1 commit into from
Dec 15, 2017

Conversation

chalettu
Copy link
Contributor

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1518056
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

@chalettu
Copy link
Contributor Author

Before Screenshot
before_tooltip

@chalettu
Copy link
Contributor Author

After Screenshot
after_tooltip

@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/586a72f17a42596690e4da2cd69df73713076e06 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@AllenBW AllenBW self-assigned this Dec 14, 2017
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 😍 😍 😍

@AllenBW AllenBW merged commit 61db90e into ManageIQ:master Dec 15, 2017
@AllenBW AllenBW deleted the menu-tooltip-issue branch December 15, 2017 20:54
simaishi pushed a commit that referenced this pull request Dec 19, 2017
BZ#1518056-Ensured tooltips do not show when drop downs are open
(cherry picked from commit 61db90e)

https://bugzilla.redhat.com/show_bug.cgi?id=1527578
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 4943b4fbf7b394a6dd64333a60097be0a883b236
Author: Allen Wight <[email protected]>
Date:   Fri Dec 15 15:54:02 2017 -0500

    Merge pull request #1345 from chalettu/menu-tooltip-issue
    
    BZ#1518056-Ensured tooltips do not show when drop downs are open
    (cherry picked from commit 61db90ef9f07dd33ba1ce6a00f43af8e90788e32)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1527578

@chalettu
Copy link
Contributor Author

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Mar 6, 2018
BZ#1518056-Ensured tooltips do not show when drop downs are open
(cherry picked from commit 61db90e)

https://bugzilla.redhat.com/show_bug.cgi?id=1536684
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Fine backport details:

$ git log -1
commit 0dde1bb5dffec799ff3c76c882ec2390a05ec9f3
Author: Allen Wight <[email protected]>
Date:   Fri Dec 15 15:54:02 2017 -0500

    Merge pull request #1345 from chalettu/menu-tooltip-issue
    
    BZ#1518056-Ensured tooltips do not show when drop downs are open
    (cherry picked from commit 61db90ef9f07dd33ba1ce6a00f43af8e90788e32)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1536684

@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

@chalettu Travis is failing in Fine branch:

/home/travis/build/ManageIQ/manageiq-ui-service/client/app/shared/custom-dropdown/custom-dropdown.component.js
  25:20  error  Missing trailing comma  comma-dangle

Guess the trailing comma isn't required in master/gaprindashvili, but required in fine branch? Can you please create a PR to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants