BZ#1525692-Hides console buttons when indicated by server sans message #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows console message in the event one exists, affects all sui supported consoles, vnc, cockpit
|
Before:
Now:
I think you may need to disable the menu dropdown if no item is visible... |
|
@himdel given the scenario you described above, we now hide the console button when there is no visibility or message with either cockpit or console |
If neither console nor cockpit is visible or has a message to display as to why the button is disabled, do not snow the access button
|
Checked commits AllenBW/manageiq-ui-service@9c12130~...9e413ff with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Jan 12, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 12, 2018
…sole-support BZ#1525692-Hides console buttons when indicated by server sans message (cherry picked from commit d21f520) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533935
|
Gaprindashvili backport details: |
|
@AllenBW There are conflicts backporting to Fine branch. Can you please create a PR for Fine branch? |
|
@simaishi BUMMER! thanks for checking! will make this happen immediately. |
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Jan 15, 2018
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Jan 15, 2018
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Jan 17, 2018
AllenBW
added a commit
to AllenBW/manageiq-ui-service
that referenced
this pull request
Jan 17, 2018
|
Backported to Fine via #1359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://bugzilla.redhat.com/show_bug.cgi?id=1525692
This work ensures we show a console message as a tooltip in the event one exists (you'll notice in both sui ss below, we indicate why cockpit is disabled)
When vnc is not selected in ops, we no longer see the option in sui
When vnc is selected in ops, we see the option in sui (you'll notice no tooltip, its only displayed when a message is present)
This work is related to https://bugzilla.redhat.com/show_bug.cgi?id=1532720