Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1533817-Enables user to revert snapshots that are parents #1358

Merged
merged 1 commit into from
Jan 12, 2018
Merged

BZ#1533817-Enables user to revert snapshots that are parents #1358

merged 1 commit into from
Jan 12, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jan 12, 2018

@AllenBW AllenBW requested a review from himdel as a code owner January 12, 2018 14:59
@AllenBW AllenBW assigned AllenBW and himdel and unassigned AllenBW Jan 12, 2018
@AllenBW AllenBW added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 12, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2018

Checked commit AllenBW@ea9f4c7 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@himdel
Copy link
Contributor

himdel commented Jan 12, 2018

The original code comes from #600

Seems straightforward enough :)

himdel
himdel approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 revert being disabled no longer depends on the parent/child status of the snapshot

@himdel himdel merged commit bf9c413 into ManageIQ:master Jan 12, 2018
@AllenBW AllenBW deleted the bug/master#1533817-revert-to-parent-snapshot branch January 12, 2018 15:24
simaishi pushed a commit that referenced this pull request Jan 12, 2018
@himdel @simaishi
Merge pull request #1358 from AllenBW/bug/master#1533817-revert-to-pa…
50bee00 
…rent-snapshot

BZ#1533817-Enables user to revert snapshots that are parents
(cherry picked from commit bf9c413)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534059
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 50bee00a1d3c48c742a3ff26a6075f999c9be9a4
Author: Martin Hradil <[email protected]>
Date:   Fri Jan 12 16:19:47 2018 +0100

    Merge pull request #1358 from AllenBW/bug/master#1533817-revert-to-parent-snapshot
    
    BZ#1533817-Enables user to revert snapshots that are parents
    (cherry picked from commit bf9c413dcc58df9e36e185bb701de769937c53fa)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534059

This was referenced Jan 19, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees

@himdel himdel

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllenBW @miq-bot @himdel @simaishi @chessbyte