Restores listview deafult row click behavior, expanding row content #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit AllenBW@e8e0682 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://bugzilla.redhat.com/show_bug.cgi?id=1525546
Aligns order explorer with pfa design, when yah click a row with expanded content, whole row expands:
http://www.patternfly.org/angular-patternfly/#/api/patternfly.views.component:pfListView
Looks like this
and yah might be thinking.. yeah Allen, nice n all but what about the
disableRowExpansionthing?That sucker is in place to not expand a row if there is nothing to expand, a pf 🐛 of yesteryear, nowahdays, when there's nothing to expand, yah see this, clicking does nada (notice the absence of the 🥕)