Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1574774 updated custom button dialog url #1433

Merged
merged 1 commit into from
May 15, 2018
Merged

BZ#1574774 updated custom button dialog url #1433

merged 1 commit into from
May 15, 2018

Conversation

chalettu
Copy link
Contributor

Fix for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1574774
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label bug

@miq-bot
Copy link
Member

miq-bot commented May 15, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/4ad7ea118efb8a67032379f7b190c38539fd1643 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@AllenBW AllenBW self-assigned this May 15, 2018
@AllenBW AllenBW self-requested a review May 15, 2018 17:09
AllenBW
AllenBW reviewed May 15, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can see what this working looks like?

@AllenBW
Copy link
Member

AllenBW commented May 15, 2018

@chalettu ☝️

@chalettu
Copy link
Contributor Author

dropdown

I thought you might ask about that. I didn't initially post one because no UI changes were made. Here is a picture of the custom button details page in SUI rendering a dropdown field properly

AllenBW
AllenBW approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😋

@AllenBW AllenBW merged commit 23046b0 into ManageIQ:master May 15, 2018
@chalettu chalettu deleted the custom-button-dialog branch May 15, 2018 20:13
simaishi pushed a commit that referenced this pull request May 16, 2018
@AllenBW @simaishi
Merge pull request #1433 from chalettu/custom-button-dialog
15248c5 
BZ#1574774 updated custom button dialog url
(cherry picked from commit 23046b0)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578990
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 15248c596a74378906cf00d8f16c346898fa3679
Author: Allen Wight <[email protected]>
Date:   Tue May 15 14:13:03 2018 -0400

    Merge pull request #1433 from chalettu/custom-button-dialog
    
    BZ#1574774 updated custom button dialog url
    (cherry picked from commit 23046b0be4a28022c0d8c5cbf81b80a96f7e2dd4)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1578990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@AllenBW AllenBW

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @AllenBW @simaishi