Change service dialog api call to match CUI #1438

d-m-u · 2018-05-23T15:14:00Z

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1578080

The classic ui api call for service dialogs is the one we should be using so we don't end up with eeeeeeeetooooomaaaaaany automate calls.

d-m-u · 2018-05-23T15:14:15Z

@eclarizio can you 👀 please?

mkanoor · 2018-05-23T15:48:47Z

client/app/states/catalogs/details/details.state.js

@@ -113,7 +113,7 @@ function Controller ($stateParams, CollectionsApi, EventNotifications, ShoppingC

  init()
  function setDialogUrl (serviceTemplateCatalogId) {
-    vm.dialogUrl = `service_catalogs/${serviceTemplateCatalogId}/service_templates`
+    vm.dialogUrl = `/api/service_dialogs/`


@d-m-u
Can we use the href_slug here? it encapsulates the internal names so this doesn't have to be aware if its called service_catalogs or service_dialogs

JPrause · 2018-05-23T18:02:46Z

@miq-bot add_label blocker

JPrause · 2018-05-23T18:03:16Z

@d-m-u if this can be backported, can you add the gaprindashvili/yes label.

d-m-u · 2018-05-23T18:50:49Z

@eclarizio ya think should this be backported?

chalettu · 2018-05-23T19:19:53Z

@d-m-u has this been tested with a drop down in a service dialog by chance?

eclarizio

The spec is broken since you didn't change it to expect the new URL, but otherwise I think it looks fine.

Also, yes, this should be backported since the BZ is requesting a fix for 5.9

eclarizio · 2018-05-23T21:08:19Z

client/app/states/catalogs/details/details.state.js

@@ -136,7 +136,7 @@ function Controller ($stateParams, CollectionsApi, EventNotifications, ShoppingC
      targetId: vm.serviceTemplate.id,
      targetType: 'service_template'
    }
-    const url = `${vm.dialogUrl}/${vm.serviceTemplate.id}`
+    const url = `${vm.dialogUrl}/${vm.dialogId}`


Ah, this won't work. You'll either have to use the id from one of the previous lines (idList.dialogId) or use vm.parsedDialogs.id.

d-m-u · 2018-05-24T14:50:55Z

@miq-bot add_label gaprindashvili/yes

eclarizio · 2018-05-24T15:27:52Z

client/app/states/catalogs/details/details.state.js

@@ -113,7 +113,7 @@ function Controller ($stateParams, CollectionsApi, EventNotifications, ShoppingC

  init()
  function setDialogUrl (serviceTemplateCatalogId) {


We can remove this argument now that we're not using it. Also will need to be removed from any callers.

d-m-u · 2018-05-24T17:40:56Z

@chalettu yeah, it looks fine

AllenBW

@d-m-u any chance yah can throw up a gif of the pr in action?

TOTALLY down with the change, just wanta seeeeeeee it... work......

d-m-u · 2018-05-29T20:22:05Z

The request and the payload with correct values:

d-m-u · 2018-05-29T20:35:44Z

@eclarizio can we address https://github.com/ManageIQ/manageiq-ui-service/pull/1438/files#diff-b46757a979791a43044bafe701ffe4dfR101 in subsequent pr?

AllenBW

LG2M

@eclarizio @chalettu yah good with this?

miq-bot · 2018-05-31T13:28:10Z

Checked commit d-m-u@03b12f0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

eclarizio

Yeah we can address the other issue in a separate PR.

👍

chalettu

LGTM. Great work

AllenBW

🌮 💃

Change service dialog api call to match CUI (cherry picked from commit c0f89fc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1585709

simaishi · 2018-06-04T13:23:50Z

Gaprindashvili backport details:

$ git log -1
commit be89d8475ec00011f837708376ac3af5d5b27671
Author: Allen Wight <[email protected]>
Date:   Thu May 31 10:51:36 2018 -0400

    Merge pull request #1438 from d-m-u/fixing_sui_api_call_to_match_cui
    
    Change service dialog api call to match CUI
    (cherry picked from commit c0f89fc93a69c40af56b98f38f99134481edfe40)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1585709

miq-bot added the wip label May 23, 2018

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch from 25aeac6 to 4b05bc5 Compare May 23, 2018 15:27

d-m-u changed the title ~~[WIP] Change service dialog api call to match CUI~~ Change service dialog api call to match CUI May 23, 2018

miq-bot removed the wip label May 23, 2018

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch from 4b05bc5 to 9a2df89 Compare May 23, 2018 15:30

d-m-u changed the title ~~Change service dialog api call to match CUI~~ [WIP] Change service dialog api call to match CUI May 23, 2018

miq-bot added the wip label May 23, 2018

mkanoor reviewed May 23, 2018

View reviewed changes

miq-bot added the blocker label May 23, 2018

eclarizio suggested changes May 23, 2018

View reviewed changes

eclarizio reviewed May 23, 2018

View reviewed changes

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch from 9a2df89 to 70f1c3d Compare May 24, 2018 14:50

miq-bot added the gaprindashvili/yes label May 24, 2018

eclarizio reviewed May 24, 2018

View reviewed changes

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch 2 times, most recently from d19e172 to 266f1d8 Compare May 24, 2018 17:17

d-m-u changed the title ~~[WIP] Change service dialog api call to match CUI~~ Change service dialog api call to match CUI May 24, 2018

miq-bot removed the wip label May 24, 2018

AllenBW reviewed May 29, 2018

View reviewed changes

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch from 266f1d8 to 6f8d6ea Compare May 29, 2018 15:04

eclarizio mentioned this pull request May 29, 2018

Ensure refresh => true option gets passed for service_template refresh ManageIQ/manageiq-api#386

Merged

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch 2 times, most recently from f0cc7c0 to 7d34a9f Compare May 29, 2018 16:47

d-m-u changed the title ~~Change service dialog api call to match CUI~~ [WIP] Change service dialog api call to match CUI May 29, 2018

miq-bot added the wip label May 29, 2018

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch 3 times, most recently from c42d731 to 8d9c6b9 Compare May 29, 2018 20:20

d-m-u changed the title ~~[WIP] Change service dialog api call to match CUI~~ Change service dialog api call to match CUI May 29, 2018

miq-bot removed the wip label May 29, 2018

AllenBW previously approved these changes May 30, 2018

View reviewed changes

Change service dialog api call to match CUI

03b12f0

d-m-u dismissed AllenBW’s stale review via 03b12f0 May 31, 2018 13:24

d-m-u force-pushed the fixing_sui_api_call_to_match_cui branch from 8d9c6b9 to 03b12f0 Compare May 31, 2018 13:24

eclarizio approved these changes May 31, 2018

View reviewed changes

chalettu approved these changes May 31, 2018

View reviewed changes

AllenBW approved these changes May 31, 2018

View reviewed changes

AllenBW merged commit c0f89fc into ManageIQ:master May 31, 2018

himdel assigned AllenBW May 31, 2018

himdel added this to the Sprint 87 Ending Jun 4, 2018 milestone May 31, 2018

simaishi pushed a commit that referenced this pull request Jun 4, 2018

Merge pull request #1438 from d-m-u/fixing_sui_api_call_to_match_cui

be89d84

Change service dialog api call to match CUI (cherry picked from commit c0f89fc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1585709

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Jun 4, 2018

d-m-u deleted the fixing_sui_api_call_to_match_cui branch July 9, 2018 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change service dialog api call to match CUI #1438

Change service dialog api call to match CUI #1438

d-m-u commented May 23, 2018 •

edited

Loading

d-m-u commented May 23, 2018

mkanoor May 23, 2018

JPrause commented May 23, 2018

JPrause commented May 23, 2018

d-m-u commented May 23, 2018

chalettu commented May 23, 2018

eclarizio left a comment

eclarizio May 23, 2018

d-m-u commented May 24, 2018

eclarizio May 24, 2018

d-m-u commented May 24, 2018

AllenBW left a comment •

edited

Loading

d-m-u commented May 29, 2018

d-m-u commented May 29, 2018

AllenBW left a comment

miq-bot commented May 31, 2018

eclarizio left a comment

chalettu left a comment

AllenBW left a comment

simaishi commented Jun 4, 2018

		@@ -113,7 +113,7 @@ function Controller ($stateParams, CollectionsApi, EventNotifications, ShoppingC

		init()
		function setDialogUrl (serviceTemplateCatalogId) {

Change service dialog api call to match CUI #1438

Change service dialog api call to match CUI #1438

Conversation

d-m-u commented May 23, 2018 • edited Loading

d-m-u commented May 23, 2018

mkanoor May 23, 2018

Choose a reason for hiding this comment

JPrause commented May 23, 2018

JPrause commented May 23, 2018

d-m-u commented May 23, 2018

chalettu commented May 23, 2018

eclarizio left a comment

Choose a reason for hiding this comment

eclarizio May 23, 2018

Choose a reason for hiding this comment

d-m-u commented May 24, 2018

eclarizio May 24, 2018

Choose a reason for hiding this comment

d-m-u commented May 24, 2018

AllenBW left a comment • edited Loading

Choose a reason for hiding this comment

d-m-u commented May 29, 2018

d-m-u commented May 29, 2018

AllenBW left a comment

Choose a reason for hiding this comment

miq-bot commented May 31, 2018

eclarizio left a comment

Choose a reason for hiding this comment

chalettu left a comment

Choose a reason for hiding this comment

AllenBW left a comment

Choose a reason for hiding this comment

simaishi commented Jun 4, 2018

d-m-u commented May 23, 2018 •

edited

Loading

AllenBW left a comment •

edited

Loading