Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retirement & provisioning playbook does not duplicate details #1443

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jun 8, 2018

closes https://bugzilla.redhat.com/show_bug.cgi?id=1589334

fixed! (what was broken? when multiple playbooks were present, provision/retirement, playbook details and stdout would mirrior the number of playbooks)
asdf

and we need to take this back to fine!

closes https://bugzilla.redhat.com/show_bug.cgi?id=1591426

@miq-bot
Copy link
Member

miq-bot commented Jun 8, 2018

Checked commit AllenBW@655fbdd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, double ng-repeat :)

@himdel himdel merged commit f1278c3 into ManageIQ:master Jun 11, 2018
@himdel himdel added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 11, 2018
@AllenBW AllenBW deleted the bug/duplicate-ansible-details branch June 11, 2018 14:35
simaishi pushed a commit that referenced this pull request Jun 12, 2018
Retirement & provisioning playbook does not duplicate details
(cherry picked from commit f1278c3)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590426
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 563570ab107b56594a9ff9eeea30e5f3400906b7
Author: Martin Hradil <[email protected]>
Date:   Mon Jun 11 16:25:35 2018 +0200

    Merge pull request #1443 from AllenBW/bug/duplicate-ansible-details
    
    Retirement & provisioning playbook does not duplicate details
    (cherry picked from commit f1278c38859aec3c85e2fe448cc38136379395ab)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1590426

simaishi pushed a commit that referenced this pull request Aug 14, 2018
Retirement & provisioning playbook does not duplicate details
(cherry picked from commit f1278c3)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591443
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 0a6a6186f6a4027acd787935deb51baf42fb89f9
Author: Martin Hradil <[email protected]>
Date:   Mon Jun 11 16:25:35 2018 +0200

    Merge pull request #1443 from AllenBW/bug/duplicate-ansible-details
    
    Retirement & provisioning playbook does not duplicate details
    (cherry picked from commit f1278c38859aec3c85e2fe448cc38136379395ab)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants