Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1600043 - Snapshot modal. Add support to hide memory checkbox #1455

Merged
merged 1 commit into from
Jul 12, 2018
Merged

BZ#1600043 - Snapshot modal. Add support to hide memory checkbox #1455

merged 1 commit into from
Jul 12, 2018

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Jul 12, 2018 •
edited
Loading

Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1600043
This allows memory checkbox to be hidden from user when the VM is in the off state.
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label bug

@chalettu
Copy link
Contributor Author

Demo of what happens when a vm is in the off state.
memory_demo

@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/ab16a14e98dcbc86dfbab04214b2de5db160b0e1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chalettu chalettu changed the title Snapshot modal -add support to hide memory checkbox BZ#1600043 - Snapshot modal -add support to hide memory checkbox Jul 12, 2018
@chalettu chalettu changed the title BZ#1600043 - Snapshot modal -add support to hide memory checkbox BZ#1600043 - Snapshot modal. Add support to hide memory checkbox Jul 12, 2018
@AllenBW AllenBW self-requested a review July 12, 2018 21:37
@AllenBW AllenBW self-assigned this Jul 12, 2018
@AllenBW AllenBW added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 12, 2018
AllenBW
AllenBW approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

Nicely done @chalettu !

@AllenBW AllenBW merged commit 43d501a into ManageIQ:master Jul 12, 2018
@JPrause
Copy link
Member

JPrause commented Sep 14, 2018

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Sep 17, 2018
@AllenBW @simaishi
Merge pull request #1455 from chalettu/snapshot-memory
a6762ee 
BZ#1600043  - Snapshot modal. Add support to hide memory checkbox
(cherry picked from commit 43d501a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1629090
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit a6762eedf50411a9fe2dc132bd2ef638c33bb225
Author: Allen Wight <[email protected]>
Date:   Thu Jul 12 17:42:24 2018 -0400

    Merge pull request #1455 from chalettu/snapshot-memory
    
    BZ#1600043  - Snapshot modal. Add support to hide memory checkbox
    (cherry picked from commit 43d501a199b5a1fcbbbf555b5ae56e38996ab676)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1629090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@AllenBW AllenBW

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalettu @miq-bot @JPrause @simaishi @AllenBW