Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] BZ#1601587 - Fixed issue with dialogs that causes duplicate values #1458

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Conversation

chalettu
Copy link
Contributor

@miq-bot add_label bug

@chalettu chalettu requested a review from AllenBW as a code owner July 16, 2018 19:27
@miq-bot miq-bot added the bug label Jul 16, 2018
@chalettu
Copy link
Contributor Author

This is the SUI implementation that fixes the bug addressed here, ManageIQ/ui-components#316

@miq-bot miq-bot changed the title BZ#1601587 - Fixed issue with dialogs that causes duplicate values [GAPRINDASHVILI] BZ#1601587 - Fixed issue with dialogs that causes duplicate values Jul 16, 2018
@AllenBW AllenBW self-assigned this Jul 16, 2018
@AllenBW AllenBW added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 16, 2018
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M cc @simaishi

@simaishi
Copy link
Contributor

@chalettu @AllenBW Are we not updating yarn.lock?

@AllenBW
Copy link
Member

AllenBW commented Jul 16, 2018

Ooooo good point, we ought to update that as well, @chalettu yah want me to drop in?

@chalettu
Copy link
Contributor Author

Repushed branch with the yarn.lock file updates

@miq-bot
Copy link
Member

miq-bot commented Jul 16, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/8816e46ce5e278b098de5ef4b8a28e2f8283e416 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@simaishi simaishi merged commit a4f1a19 into ManageIQ:gaprindashvili Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants