Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last retire call to make request #1459

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Jul 17, 2018

I forgot about this silly thing here, mea maxima culpa. It's the rest of #1453.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599299

@d-m-u
Copy link
Contributor Author

d-m-u commented Jul 17, 2018

@miq-bot add_label bug, blocker
@chalettu can you please review?

@AllenBW
Copy link
Member

AllenBW commented Jul 17, 2018

@d-m-u any chance we can get a gif or ss of this workin as desired?

@AllenBW AllenBW added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 17, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Jul 17, 2018

The request payload showing the updated call (used to just be retire):
screen shot 2018-07-17 at 9 37 30 am

The CUI showing the newly created request:
screen shot 2018-07-17 at 9 37 45 am

@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2018

Checked commit d-m-u@a4acf5e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Contributor

@chalettu chalettu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the screenshots.

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!! This feels like a future bug avoided 😏 😋

@AllenBW AllenBW merged commit 4dcc983 into ManageIQ:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants