Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1601527 - Fixed issue with retire modal coming up blank #1461

Merged
merged 1 commit into from
Jul 17, 2018
Merged

BZ#1601527 - Fixed issue with retire modal coming up blank #1461

merged 1 commit into from
Jul 17, 2018

Conversation

chalettu
Copy link
Contributor

Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1601527

A recent change as part of #1453 caused the modal to not show up as expected.
@miq-bot add_label bug

@chalettu
Copy link
Contributor Author

chalettu commented Jul 17, 2018

Screenshot of modal in action
modal_retire

@miq-bot miq-bot added the bug label Jul 17, 2018
@AllenBW AllenBW self-requested a review July 17, 2018 19:54
@AllenBW AllenBW self-assigned this Jul 17, 2018
@AllenBW AllenBW added blocker and removed blocker labels Jul 17, 2018
@AllenBW AllenBW added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 17, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/ac0e34041bf5d65c87af732d609aac497c5e7d42 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @chalettu!!!

@AllenBW AllenBW merged commit a5e6333 into ManageIQ:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants