Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ#1630119 - Hide revert snapshot button for openstack vm's #1475

Merged
merged 1 commit into from
Sep 19, 2018
Merged

BZ#1630119 - Hide revert snapshot button for openstack vm's #1475

merged 1 commit into from
Sep 19, 2018

Conversation

chalettu
Copy link
Contributor

Fixes BZ 1630119.
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

@chalettu
Copy link
Contributor Author

Before SS
before
After SS
after

@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/c4047abf8ec858fd8d469df7799f6e530f1e37ef with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@AllenBW AllenBW self-requested a review September 19, 2018 17:55
@AllenBW AllenBW added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 19, 2018
AllenBW
AllenBW approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌮 💃

the bz link: https://bugzilla.redhat.com/show_bug.cgi?id=1630119

@chalettu
Copy link
Contributor Author

Just for reference, here is the corresponding line that hides this same functionality in the classic ui
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/button/vm_snapshot_revert.rb#L5

@AllenBW AllenBW merged commit 41213c6 into ManageIQ:master Sep 19, 2018
simaishi pushed a commit that referenced this pull request Nov 7, 2018
@AllenBW @simaishi
Merge pull request #1475 from chalettu/openstack-revert-snap
dc0fb73 
BZ#1630119 - Hide revert snapshot button for openstack vm's

(cherry picked from commit 41213c6)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635788
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2018

Gaprindashvili backport details:

$ git log -1
commit dc0fb73bfc7b0b86b3e666c11bddaa6541beaa35
Author: Allen Wight <[email protected]>
Date:   Wed Sep 19 14:06:57 2018 -0400

    Merge pull request #1475 from chalettu/openstack-revert-snap
    
    BZ#1630119 - Hide revert snapshot button for openstack vm's
    
    (cherry picked from commit 41213c6af5047f9d5ff3fd2f22ce4190b2120bf5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees
No one assigned
Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalettu @miq-bot @simaishi @AllenBW