BZ#1650693 If tagging is readonly we should not show the edit dropdown #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But if tagging is not read only, behavior is nominal
|
Checked commit AllenBW@2300d49 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Nov 19, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2018
…y-issue BZ#1650693 If tagging is readonly we should not show the edit dropdown (cherry picked from commit 953635b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650693
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But if tagging is not read only, behavior is nominal
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650693
see, no more edit dropdown here (where we shouldn't have one)
but we can still do tagging where we need to !