BZ#1653288 Service is getting retired without any confirmation in self service ui #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit AllenBW@da7fc9c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Nov 28, 2018
AllenBW
deleted the
BZ/#1653288-Serviceisgettingretiredwithoutanyconfirmationinselfserviceui
branch
simaishi
pushed a commit
that referenced
this pull request
Dec 3, 2018
…iredwithoutanyconfirmationinselfserviceui BZ#1653288 Service is getting retired without any confirmation in self service ui (cherry picked from commit d163312) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653288
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653288
A confirmation modal was never present on this command (the retire now menu item). But the response to the action, the hardcoded text was inaccurate, the service isn't retired upon clicking, a retire service request is created, update the response notifications to use the api feedback rather than hardcoded text.
Message on success
Message on error