BZ#1644250 - Added ability for documentation to be dynamically configured #1505
Conversation
|
Checked commit https://github.com/chalettu/manageiq-ui-service/commit/ee99917cc66486ab501f3d85d42170ae968dd097 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
|
||
| CollectionsApi.query('settings/help_menu/documentation').then((data) => { | ||
| const documentation = data.help_menu.documentation | ||
| const matches = documentation.href.match(/http.*(http.*)/) |
There was a problem hiding this comment.
What if this ends up being https? still work?
There was a problem hiding this comment.
should continue to work fine because .* accounts for any character after http. I wrote it intentionally so it would accept http:// or https:// .
|
@miq-bot add_label blocker |
|
@chalettu any chance we can get a ss of a custom documentation url? I just tested this on my end, didn't see it take (but also didn't see cui take either) |
|
Screenshot of documenation link going to a Redhat Rhel product info page instead of default documenation page. |
BZ#1644250 - Added ability for documentation to be dynamically configured (cherry picked from commit 224193f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1644250
|
Hammer backport details: |
BZ#1644250 - Added ability for documentation to be dynamically configured (cherry picked from commit 224193f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655769
|
Gaprindashvili backport details: |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1644250
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label hammer/yes