Unshift the placeholder message rather onto filtered tags #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenBW
force-pushed
the
BZ/#1646925-missing-tag-values
branch
2 times, most recently
from
9de86ab
to
6d7acca
Compare
Previous implementation replaced first tag option with this 🙀😑
AllenBW
force-pushed
the
BZ/#1646925-missing-tag-values
branch
from
6d7acca
to
cddca29
Compare
|
Checked commit AllenBW@cddca29 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
himdel
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Verified 👍
IMO we should never be putting the "choose" option in the list itself,
but that may be a bigger refactoring, this fixes the problem :).
(In the future, we should probably replace the tagging component with the one @PanSpagetka created in ManageIQ/react-ui-components#3.)
|
agreed and agreed! |
simaishi
pushed a commit
that referenced
this pull request
Dec 12, 2018
Unshift the placeholder message rather onto filtered tags (cherry picked from commit 7cf8ddc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1646925
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1646925
Previous implementation replaced first tag option with this 🙀😑
Look you see cost center 001 and 002!!!