RBAC - use sui_dashboard_show instead of the sui_dashboard folder for VIEW dashboard permission #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
changed the title
…VIEW dashboard permission this way, when the new "View Dashboard" feature is not set, there will be no Dashboard https://bugzilla.redhat.com/show_bug.cgi?id=1783356
|
Checked commit https://github.com/himdel/manageiq-ui-service/commit/a2ca46235701af52484f3cde0c4c89ade07873bb with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@himdel can this be |
|
Sure, this should only depend on ManageIQ/manageiq#19657, added :) |
simaishi
pushed a commit
that referenced
this pull request
Feb 21, 2020
RBAC - use sui_dashboard_show instead of the sui_dashboard folder for VIEW dashboard permission (cherry picked from commit a26bac2) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805806
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq#19657
This way, when the new "View Dashboard" feature is not set, there will be no Dashboard
https://bugzilla.redhat.com/show_bug.cgi?id=1783356
both "view dashboard" and "monthly charge view" on:
only "view dashboard":
no "view dashboard" (regardless of "monthly charge view")