Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings.help_menu.documentation - Fix missing href "Cannot read property 'match' of undefined" #1628

Merged
merged 1 commit into from
Feb 4, 2020
Merged

settings.help_menu.documentation - Fix missing href "Cannot read property 'match' of undefined" #1628

merged 1 commit into from
Feb 4, 2020

Commits on Feb 3, 2020

  1. settings.help_menu.documentation - Fix missing href "Cannot read prop… 

    …erty 'match' of undefined"

The code assumes settings.help_menu.documentation contains a href, and fails without it.

But the href is there only if we want to override the link, fixing.

Also, the original code expects the href to always be http://api_location/api/http://the_href.com ,
now it will parse that if present, but fall back to just using the href if not.
    @himdel
    himdel committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    638d471 View commit details
    Browse the repository at this point in the history